urschrei / pyzotero

Pyzotero: a Python client for the Zotero API
https://pyzotero.readthedocs.org
Other
908 stars 99 forks source link

Missing feedparser classes #117

Closed moorepants closed 4 years ago

moorepants commented 4 years ago

General

If at all possible, provide a MVCE. If this is inappropriate (e.g. it's obviously a bug), just fill in the below:

Platform: Ubuntu 20.04 Python version: 3.7 Pyzotero version: 1.4.16

Problem description

I tried the calling Zotero() and get this error:

~/miniconda/lib/python3.7/site-packages/pyzotero/zotero.py in <module>
    103 
    104 # Override feedparser's buggy isBase64 method until they fix it
--> 105 feedparser._FeedParserMixin._isBase64 = ib64_patched
    106 
    107 

AttributeError: module 'feedparser' has no attribute '_FeedParserMixin'

If possible, paste the full traceback in a code block below, and fill in the summary

Traceback code goes here, indented with four spaces
moorepants commented 4 years ago

Note that his error is not present if feedparser's version is < 6. It is likely a breaking change feedparser made in version 6.

urschrei commented 4 years ago

Did you manually install Feedparser 6.0.1? Pyzotero's Feedparser version is pinned to 5.2.1 as the 6.x series isn't compatible with Python 2 or Python 3 versions below 3.6…

moorepants commented 4 years ago

It looks like the pyzotero conda feedstock is >=5.2.1 not ==5.2.1. Should it be >=5.2.1,<6 ?

urschrei commented 4 years ago

Yep, there's the problem.

urschrei commented 4 years ago

Just pushed the v1.4.18 tag and release to PyPI to fix this. The bot should pick it up…

moorepants commented 4 years ago

Ok, the bot won't correct the dependencies in the meta.yaml file though. That still has to be done manually.

urschrei commented 4 years ago

OK, edited the bot PR to use feedparser <6.0.0, and merged.

moorepants commented 4 years ago

I made a comment on the PR. I think you want to set lower and upper bounds.

urschrei commented 4 years ago

Ah, wasn't sure whether I could do that. Sorry for jumping the gun! Opened a fresh PR at: https://github.com/conda-forge/pyzotero-feedstock/pull/18