search

urschrei / pyzotero

Pyzotero: a Python client for the Zotero API
https://pyzotero.readthedocs.org
Other
908 stars 99 forks source link

Fix new_fulltext() ignoring the version parameter. #136

Closed davidlesieur closed 3 years ago

davidlesieur commented 3 years ago

The new_fulltext() method was not using the since= query string when calling the Zotero API. Thus the version specified by the caller was always ignored.

This PR also renames the version parameter to since. The latter seems more consistent with other Pyzotero method parameters, and with the Zotero API. The Pyzotero docs also mention since, not version, although no one using positional parameters would notice.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.05%) to 47.368% when pulling fdc517f88cff817ea4c702ea70c34377a61cccba on davidlesieur:new-fulltext-since into 3a07628d8b3e665f8274c1b62e26d7e53679519f on urschrei:dev.

urschrei commented 3 years ago

Oh, hmm I wonder why I had originally set it as a header and not part of the query string. Thanks for this – I'll review and merge it tomorrow and push out a point release.