Make sure that the modified header value is always a string

urschrei / pyzotero

Pyzotero: a Python client for the Zotero API

https://pyzotero.readthedocs.org

Other

911 stars 100 forks source link

Make sure that the modified header value is always a string #61

Closed ghost closed 8 years ago

ghost commented 8 years ago

As I found out while using jbaiter/zotero-cli, it is possible to create a Zotero API request using this library that results in the creation of a "if-unmodified-since" header with an integer value that is then handed over to the requests module.
See kennethreitz/requests#3477 for a change in that module that causes integer values to create an error
This pull request makes sure that the value of the "if-unmodified-since" header field is always a string.

coveralls commented 8 years ago

Coverage remained the same at 40.924% when pulling aa537d72f452de4e1b7119eb144c0dd8ad99d274 on mrbiber:no_integer_headers_2 into 6a8d0d6fcfc0bbdf0ff246efa2039f5981352dfd on urschrei:dev.

urschrei commented 8 years ago

Merged and released to PyPI as v1.1.19, which should fix subsequent zotero-cli installs. Thanks!