search

urschrei / simplification

Very fast Python line simplification using either the RDP or Visvalingam-Whyatt algorithm implemented in Rust
Other
168 stars 18 forks source link

Make numpy optional #25

Closed utapyngo closed 2 years ago

utapyngo commented 2 years ago

Refactor cutil.pyx to avoid repetitions Fix docstrings

utapyngo commented 2 years ago

stryd/fetch-release-asset requires an access token to get rustlib.zip, that's why the checks are failing.

utapyngo commented 2 years ago

@urschrei could you please review this?

utapyngo commented 2 years ago

@urschrei who can review this?

utapyngo commented 2 years ago

@urschrei The tests have passed: https://github.com/utapyngo/simplification/runs/5641757985

urschrei commented 2 years ago

Hi @utapyngo, sorry for the delay at my end. I'll try to find time for a proper review this week, but in general these changes look good. I need to have a look at some details around Numpy installation and benchmarks, but we should be able to merge if those are OK.

utapyngo commented 2 years ago

@urschrei I have removed Cython from install_requires as it does not seem to be required for simplification to work. Am I correct?

simplification does not have runtime dependencies anymore 🎉

utapyngo commented 2 years ago

@urschrei could you please review?

urschrei commented 2 years ago

Hi @utapyngo could you rebase against master, and then let's see about merging this…

utapyngo commented 2 years ago

Hi @utapyngo could you rebase against master, and then let's see about merging this…

Done.

utapyngo commented 2 years ago

Anyone here?