uruba
commented
8 years ago Awesome, thanks for your contribution. I'd however like to discuss some points with you before merging this, so that the code is consistent:
- the naming of the methods/variables – I have used exclusively camel case all throughout the project so, for the sake of consistency, it would be best to stick to it also here (although I might agree that it may disrupt the clarity with the long names [some of which may be too difficult to distinguish at a first glance], it's a project-wide problem and as such it should also be tackled project-wide [which is something we may further discuss; if you want, you can definitely tell me what do you think would be the best according to you])
- indentation – should be 4 spaces every level
- unit tests – a new test method/assertion should be added for every new feature so that it can be assessed that it is working properly at any given project state (the unit test file for these classes are DebtAmortizatorTest.php and MathFuncsTest.php)
You definitely don't have to make any changes if you don't want to, I can do this instead as an additional commit. Also discussion is welcome if you have any remarks on this.
alloylab
added round_up & round_down to mathfuncs, added debtSingleRepayment_Rounded & debtRepayments_Rounded to DebtAmortizator… added beginning and ending balance to test round math worked out. Decided to keep since I think it would be nice have in there. Rounding logic was decided on when testing against a couple official amortization schedules