uruk-project / Jwt

JSON Web Token implementation for .Net & .Net Core
MIT License
82 stars 13 forks source link

Fix JWT writing when the `JwtWriter` is used twice with the same header. #486

Closed ycrumeyrolle closed 4 years ago

ycrumeyrolle commented 4 years ago

The payload were not flushed and the JWT generation failed.

codecov[bot] commented 4 years ago

Codecov Report

Merging #486 into master will increase coverage by 0.13%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   62.96%   63.09%   +0.13%     
==========================================
  Files         165      165              
  Lines        8762     8772      +10     
  Branches     1448     1448              
==========================================
+ Hits         5517     5535      +18     
+ Misses       2723     2718       -5     
+ Partials      522      519       -3     
Impacted Files Coverage Δ
src/JsonWebToken/JwsDescriptor.cs 59.89% <100.00%> (+2.98%) :arrow_up:
src/JsonWebToken/Cryptography/Sha256.cs 96.00% <0.00%> (+0.03%) :arrow_up:
src/JsonWebToken/Cryptography/Sha512.cs 93.14% <0.00%> (+0.05%) :arrow_up:
src/JsonWebToken/Cryptography/Sha384.cs 75.24% <0.00%> (+0.75%) :arrow_up:
src/JsonWebToken/JsonHeaderCache.cs 22.58% <0.00%> (+3.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c6a997...4c7faa8. Read the comment docs.