search

uruk-project / Jwt

JSON Web Token implementation for .Net & .Net Core
MIT License
80 stars 13 forks source link

Bug fix. #539

Closed olivier-spinelli closed 3 years ago

olivier-spinelli commented 3 years ago

Hello,

I found a bug in the JSonObject.Add when a single member is updated. This PR is based on 2 commits:

Hope it helps and I want to say that I like very much your implementation that I'm starting to use in one of our project. Would you accept contributions and remarks?

For instance, in this exact JSonObject.Add case: it's actually an Update/Set - it could even be aliased by a the this[] indexer.

Thanks for this great job (and I really hope to be able to contribute to this project)!

ycrumeyrolle commented 3 years ago

Hi, contributions are welcome!

ycrumeyrolle commented 3 years ago

Fix #540

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ec14a68). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #539   +/-   ##
=========================================
  Coverage          ?   64.74%           
=========================================
  Files             ?      216           
  Lines             ?    10485           
  Branches          ?     1684           
=========================================
  Hits              ?     6789           
  Misses            ?     3145           
  Partials          ?      551

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec14a68...4173b0c. Read the comment docs.

ycrumeyrolle commented 3 years ago

Superseded by #544