search

urw7rs / spiralpp

A pytorch implementation of spiral++
Apache License 2.0
9 stars 6 forks source link

Bug in libmypaint environment #4

Open fokx opened 3 years ago

fokx commented 3 years ago

Thanks for this awesome repo! I found a minor bug in libmypaint environment. When update brush parameters, there is a minor error in the following lines: https://github.com/urw7rs/spiral-envs/blob/db1aaade8ddc98b8471c1997fb8dbcab5a7ed805/spiral/envs/libmypaint.py#L369 https://github.com/urw7rs/spiral-envs/blob/db1aaade8ddc98b8471c1997fb8dbcab5a7ed805/spiral/envs/libmypaint.py#L641 where _update_brush_params(y=y, x=y) should be _update_brush_params(y=y, x=x)

urw7rs commented 3 years ago

Thanks for finding the bug! I'll fix it

urw7rs commented 3 years ago

I found the same bug in fluid.py. So I checked the original repo and it had the same bug. x=y is only used when flag=0 as seen here. I'll check if x=y is correct or x=x is correct using deepmind/spiral repository