search

usa-npn / cales-thermal-calendars

Estimating trends in phenology in the northeastern US
https://usa-npn.github.io/cales-thermal-calendars/spatial-trends-report.html
MIT License
0 stars 0 forks source link

Reproducibility audit #7

Closed Aariq closed 6 months ago

Aariq commented 6 months ago

It would probably be a good time for someone (@diazrenata) to check this repo for reproducibility and do a general code review. You probably want to change the years target to be a subset of just a few years since downloading all the data takes quite a long time (https://github.com/usa-npn/cales-thermal-calendars/blob/f77ce46e8ba394af9d717f9f215e9d9ffcd48983/_targets.R#L56)

diazrenata commented 6 months ago

Error on getting to the normals_summary targets:

Last error message:
    error in evaluating the argument 'x' in selecting a method for function 'app': [subset] invalid name(s)
Last error traceback:
    summarize_normals(gdd_doy_stack_1000)
    terra::app(stack[[as.character(years)]], function(x) c(mean = mean(x,   ...
    stack[[as.character(years)]]
    stack[[as.character(years)]]
    .local(x, i, j = j, ...)
    subset(x, i, NSE = FALSE)
    subset(x, i, NSE = FALSE)
    .local(x, ...)
    error("subset", "invalid name(s)")
    stop("[", f, "] ", emsg, ..., call. = FALSE)
    .handleSimpleError(function (cond)  .Internal(C_tryCatchHelper(addr, 1L,...
    h(simpleError(msg, call))
    .handleSimpleError(function (condition)  {     state$error <- build_mess...
    h(simpleError(msg, call))
diazrenata commented 6 months ago

Otherwise, the pipeline runs without issue for me.

Aariq commented 6 months ago

Thank you for testing it out!