search

usa-npn / rnpn

R client for the National Phenology Network database API
https://rdrr.io/cran/rnpn/
Other
19 stars 9 forks source link

Windows binaries #13

Closed sckott closed 9 years ago

sckott commented 9 years ago

@krlmlr I'm trying to get windows binaries built on appveyor builds. I think it worked, I followed your example here https://github.com/ropensci/rnpn/blob/master/appveyor.yml#L41-L42 and the binary is here https://ci.appveyor.com/project/sckott/rnpn/build/artifacts

But in https://github.com/krlmlr/r-appveyor/issues/5#issuecomment-52367532 you said you still need to call R CMD INSTALL, which I don't think I did in the appveyor.yml file. What am I missing?

krlmlr commented 9 years ago

I think you're fine if the .zip is created and offered as artifact. R CMD INSTALL --build is called in my r-travis fork, and now (per craigcitro/r-travis#134) also in the "official" version. Currently, r-appveyor uses my fork of r-travis but I think there's no need for it anymore.

sckott commented 9 years ago

Okay, thanks. By the way, how do we get OSX binaries on Travis? From googling, seems you have to use a separate Ruby gem to send binaries to S3 or elsewhere?

krlmlr commented 9 years ago

I haven't tried getting artifacts out of r-travis yet, but last time I checked Travis wouldn't host artifacts for you. Take a look at craigcitro/r-travis#135 for an approach to have r-travis create a GitHub release (with attachment) for a successful build.

sckott commented 9 years ago

Thanks @krlmlr !