search

usabilla / button-generator

Node module that generates a button image.
1 stars 0 forks source link

Refactoring #5

Closed kagnamazian closed 7 years ago

kagnamazian commented 7 years ago

Closes FED-.

Reviewers: @spirosikmd @pietvanzoen @beerecca @kdabo @tjinauyeung

Notes for Testing:

Since I changed the structure. I am trying to be as logic as possible, I'm still doubting about some decision I took maybe you can give me feedback if it clear/correct ? For now, the tests are not running (since I changed the entire class) But I want to know if I am going to the right way before writing my unit-test.

kagnamazian commented 7 years ago

I was looking other library about Manage virtual Dom and i found quickly this one who look better than the one we are using https://github.com/Matt-Esch/virtual-dom Moreover it has a render function which could help us to have promise. What do you think ? Should I replace it too ?

spirosikmd commented 7 years ago

Oh my last comment shows outdated @katia-agna but it still applies!

kagnamazian commented 7 years ago

@spirosikmd I implemented a buttonSVG Class I also changed with the new npm module : VirtualDom (I forgot to specify that in my commit)

beerecca commented 7 years ago

So as to keep your sanity, I've made the couple of extra changes myself in the "Last tidying" commit :) Mainly text tidying, removing unused file, and renaming options.color to options.textColor (color is too generic - I didn't mean match the properties to the client, they should match the api model).

kagnamazian commented 7 years ago

Yep agree for the parameters ! Thanks Rebecca ! sorry for the english mistakes ;)

beerecca commented 7 years ago

No worries!