search

usablica / intro.js

Lightweight, user-friendly onboarding tour library
http://introjs.com
Other
22.79k stars 2.59k forks source link

intro.js 3.1.0 shows the `introjs-skipbutton` even with `showButtons: false` #1100

Open aried3r opened 3 years ago

aried3r commented 3 years ago

Description

In intro.js 3.1.0 the button with the class introjs-skipbutton is shown, even when showButtons is set to false. intro.js 2.9.3 did not have this behavior.

Except for https://github.com/usablica/intro.js/issues/1093 I was unable to find any information to the change in behavior to the buttons in 3.0.0 and 3.1.0.

Expected Behavior

Don't show the skip button when showButtons is set to false.

Actual Behavior

The skip button is shown then showButtons is set to false.

Example (recommended)

Demo with version 3.1.0: https://jsfiddle.net/ta3ex8qw/1/ Demo with version 2.9.3: https://jsfiddle.net/mdvuk638/2/

afshinm commented 3 years ago

Hey @aried3r. That's right. The skip button has been change since v3 and showButtons flag doesn't control the skip button anymore.

I'm happy to add another option to hide the skip button though.

aried3r commented 3 years ago

Would it be possible to add this to the changelog on the releases page and maybe the documentation? It seems there were some behavioral changes from 2.9.3 that haven't been documented (see also #1093).

I'm currently hiding the button and the title via CSS instead, since the title seems to use 10px of space, even if it is not used.

Thanks btw, for keeping this project alive!

NiushaSedighiK commented 3 years ago

Is there any progress on this? I'd also appreciate an option to hide the skip button

didaquis commented 2 years ago

I'd also appreciate an option to hide the skip button

Me too!