search

usablica / intro.js

Lightweight, user-friendly onboarding tour library
http://introjs.com
Other
22.85k stars 2.59k forks source link

Typescript definitions #1561

Open wouter-leistra opened 2 years ago

wouter-leistra commented 2 years ago

Description

Can introjs come with its own official typescript definitions like @types/introjs. There is some externally maintained one going around but when new features are introduced those do not get updated, like when the Got it button hide option was introduced last fall. So we had to start to maintain our own version based on the external one, but it is kind of a messy exercise.

afshinm commented 2 years ago

Sounds good. I was planning on converting the codebase to TS. That would also solve this issue.

s00d commented 2 years ago

I already did more than a year ago, but there is silence in the pull request https://github.com/usablica/intro.js/pull/1139

afshinm commented 2 years ago

Yep, sorry about that @s00d. Moving to TS is desirable and that's what I intend to do, but it requires a lot of manual testing. I'm currently working on improving our test coverage (Cypress in particular) which would make this transition easier for us. Thanks again for your patient. I'm hoping to have some updates soon.

s00d commented 2 years ago

Yep, sorry about that @s00d. Moving to TS is desirable and that's what I intend to do, but it requires a lot of manual testing. I'm currently working on improving our test coverage (Cypress in particular) which would make this transition easier for us. Thanks again for your patient. I'm hoping to have some updates soon.

Hello, updated