search

usablica / intro.js

Lightweight, user-friendly onboarding tour library
http://introjs.com
Other
22.8k stars 2.59k forks source link

Attribute data-hint is chosen unlucky #559

Closed mambax closed 3 years ago

mambax commented 8 years ago

I really love the new tooltips, the small dots, awesome!!!

Although I discovered a small conflict which disturbs our (and maybe others) applications:

The library HINT.CSS uses data-hint as selector too. Their hints are slightly different from yours, being on hover and having no dot (which we also need).

Now as you can imagine of course they clash on the data attribute.

I'd be happy to fork and create a pull request and suggest changing the data attributes everywhere to data-introjs-* to avoid any other possible clash.

Any thoughts?

mambax commented 8 years ago

519 would also be resolved by this in btw.

bozdoz commented 7 years ago

I like this idea, and agree that it should help reduce any potential conflicts.

seanwalsh commented 6 years ago

I think across the board the data-attributes need a little better namespace. We ran into an issue where we had already used data-step and had to rescope that so we didn't have any conflicts. So something like data-introjs-step would be better.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.