usagi-coffee / tree-sitter-abl

OpenEdge ABL grammar for tree-sitter
MIT License
5 stars 1 forks source link

Parameters of external procedure call are not parsed #65

Closed eglekaz closed 1 day ago

eglekaz commented 2 weeks ago

Example: run getMyNumber.p(piFirstNum, piSecNum).

Calls for internal procedures are being parsed correctly.

Reference: https://documentation.progress.com/output/ua/OpenEdge_latest/pdsoe/PLUGINS_ROOT/com.openedge.pdt.langref.help/rfi1424920323961.html

jkbz64 commented 2 weeks ago

If you see abl_statement node in the AST output it means the statement is simply not implemented yet, abl_statement node is just a filler to make more code "parsable" and it is meant to be deleted somewhere along the line if the parser manages to implement every statement (press x to doubt)

eglekaz commented 2 weeks ago

Thank you for explanation! These errors do not break our logic, so I will close this issue for now.

jkbz64 commented 2 weeks ago

Nah, it's fine to reopen this issue, it's that this issue is not about parameters, it's more "Run statement is not yet implemented".