search

usagi-flow / evil-helix

Bringing the Helix editor to the evil side
https://github.com/usagi-flow/helix
Mozilla Public License 2.0
280 stars 7 forks source link

c in visual mode doesn’t change the selection #33

Open dnaq opened 2 months ago

dnaq commented 2 months ago

Summary

Selecting a word in visual mode and then hitting c does not immediately delete the selection and switch to insert mode, instead it acts like c in normal mode, waiting for a movement to be entered.

Reproduction Steps

I tried this: 1. `hx` 2. Select any word in visual mode 3. Hit `c` I expected this to happen: That the selection immediately be deleted, and the mode switched to insert mode. Instead, this happened: The `c` command from normal mode ### Helix log _No response_ ### Platform Linux ### Terminal Emulator tmux ### Installation Method flake ### Helix Version 2dc286a
usagi-flow commented 2 months ago

Thank you for reporting this issue. I did not manage to reproduce it, however. c in visual mode immediately clears the selection and switches to insert mode. I did try it in a few different environments and on nix-darwin, but didn't notice anything unusual.

I haven't tried it with the flake though, I wonder if you're getting upstream helix binaries from cachix...

Mind checking if the problem persists with a different installation method? Maybe nix-shell -p evil-helix if you have an up-to-date unstable channel?

dnaq commented 2 months ago

Sorry for that, my bug report was lacking detail. This only seems to happen when making a selection using helix quickjump feature (gw), so selecting a word with gw and then pressing c seems to reproduce the issue.

usagi-flow commented 2 months ago

Oh, I see now; when you initiate a jump while in normal mode, it'll perform a selection, but stay in normal mode, which in turn results in the behavior you described. I'll have to vimify gw.