search

usagov / pangolin

4 stars 0 forks source link

Brakeman static security scan #40

Closed rahearn closed 2 years ago

rahearn commented 2 years ago

Adds brakeman for security scanning

closes #39

github-actions[bot] commented 2 years ago

Pa11y Failures detected

Show failure message ``` ```
hartsick commented 2 years ago

Nevermind, now that I'm digging in I see that brakeman doesn't require the database setup! ✅

rahearn commented 2 years ago

I'm curious about why you pulled out the database setup into its own task

So that I wouldn't have to specify the services: postgres part of each workflow for tasks that didn't require it.

One thing I probably could have done instead (and maybe we should do this) is to keep setup-project as it was, but pull the language setup into its own thing that can be used from within setup-project and also in actions that don't require the db