usaybia / srophe-eXist-app

eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
1 stars 0 forks source link

Tweak entry citations #36

Closed nathangibson closed 3 years ago

nathangibson commented 4 years ago

I'd like to tweak the appearance of the citations and also fix some things that aren't working correctly.

Currently https://dev.usaybia.net/person/1 shows

Nathan P. Gibson et al., “ʿAbbād ibn ʿAbbās” in last modified 2020, https://usaybia.net/person/1. Bibliography: Nathan P. Gibson et al., “ʿAbbād ibn ʿAbbās.” In , edited by . Syriaca.org, 2016-. Entry published 2020. https://usaybia.net/person/1. About this Entry Entry Title: ʿAbbād ibn ʿAbbās

Authorial and Editorial Responsibility: Nathan P. Gibson, general editor, Ludwig Maximilian University of Munich (Ludwig-Maximilians-Universität München) , editor, Vanessa Birkhahn, Fabio Ioppolo, Nadine Löhr, Robin Schmahl, Malinda Tolay, Nathan P. Gibson, Vanessa Birkhahn, Fabio Ioppolo, Nadine Löhr, Robin Schmahl, and Malinda Tolay, entry contributors, “ʿAbbād ibn ʿAbbās”

I'll take it point by point:

Nathan P. Gibson et al.

in last modified

We're not using seriesStmt -- irrelevant for this resource. Do we need a titleStmt/title[@level="m"] or what for the containing resource?

last modified 2020

In , edited by .

Where can we record the editor of the entire resource if we're not using seriesStmt?

Syriaca.org, 2016-.

Where does this text come from? publicationStmt/authority correctly has Usaybia.net.

Entry published 2020.

Where does this text come from?

, editor,

Why is there an empty editor?

wsalesky commented 4 years ago

@nathangibson The empty editors are coming from here: https://github.com/usaybia/srophe-eXist-app/blob/master/resources/xsl/citation.xsl#L232

and here: https://github.com/usaybia/srophe-eXist-app/blob/master/resources/xsl/citation.xsl#L100

You do not have any general editors. I can make it conditional, or you can change the rule to match a different role.

Where can we record the editor of the entire resource if we're not using seriesStmt?

Perhaps you could use the publication statement? This might be more a question for @davidamichelson. We can code for whatever you decide is best.

nathangibson commented 4 years ago

OK, sure, I assume you mean general editors directly under titleStmt? I can add it there.

nathangibson commented 4 years ago

Thanks for pointing out the citation.xsl file. Didn't know about that -- will take a look. I could see some logic for abstracting the citation a bit more to be useable by other projects, at least where it says "Syriaca.org", which could perhaps come from publicationStmt/authority. What do you think?

wsalesky commented 4 years ago

@nathangibson Interesting, I believe this is already changed in the Srophe app, just did not make it to Usaybia when I merged in the updates. I will double check though.

wsalesky commented 4 years ago

@nathangibson I think this is fixed. Please reopen if you find it is not.

nathangibson commented 4 years ago

Still some issues here -- will try to fix

wsalesky commented 4 years ago

@nathangibson Do you need me to do anything on this issue?

nathangibson commented 3 years ago

I think this is good now, thanks!