Closed nathangibson closed 3 years ago
@nathangibson The empty editors are coming from here: https://github.com/usaybia/srophe-eXist-app/blob/master/resources/xsl/citation.xsl#L232
and here: https://github.com/usaybia/srophe-eXist-app/blob/master/resources/xsl/citation.xsl#L100
You do not have any general editors. I can make it conditional, or you can change the rule to match a different role.
Where can we record the editor of the entire resource if we're not using seriesStmt?
Perhaps you could use the publication statement? This might be more a question for @davidamichelson. We can code for whatever you decide is best.
OK, sure, I assume you mean general editors directly under titleStmt? I can add it there.
Thanks for pointing out the citation.xsl file. Didn't know about that -- will take a look.
I could see some logic for abstracting the citation a bit more to be useable by other projects, at least where it says "Syriaca.org", which could perhaps come from publicationStmt/authority
. What do you think?
@nathangibson Interesting, I believe this is already changed in the Srophe app, just did not make it to Usaybia when I merged in the updates. I will double check though.
@nathangibson I think this is fixed. Please reopen if you find it is not.
Still some issues here -- will try to fix
@nathangibson Do you need me to do anything on this issue?
I think this is good now, thanks!
I'd like to tweak the appearance of the citations and also fix some things that aren't working correctly.
Currently https://dev.usaybia.net/person/1 shows
I'll take it point by point:
editor[@role="creator"]
(no et al)We're not using seriesStmt -- irrelevant for this resource. Do we need a
titleStmt/title[@level="m"]
or what for the containing resource?editionStmt/edition/@n
. I see there are two dates in the publicationStmt. Will the full date be displayed once I remove the extra one?Where can we record the editor of the entire resource if we're not using seriesStmt?
Where does this text come from? publicationStmt/authority correctly has Usaybia.net.
Where does this text come from?
Why is there an empty editor?