usb-tools / USBProxy-legacy

A proxy for USB devices, libUSB and gadgetFS - this project is unmaintained, try here: https://github.com/usb-tools/Facedancer
GNU General Public License v2.0
442 stars 104 forks source link

Completion of error handling #10

Open elfring opened 10 years ago

elfring commented 10 years ago

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

dominicgs commented 10 years ago

We definitely need to do this sort of thing. The code was originally a proof of concept and we were aware that we weren't bothering to check return values, etc. Now that it's getting a little more attention I think it's about time we cleaned things up.

elfring commented 10 years ago

Are you interested to apply aspect-oriented software development? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

dominicgs commented 10 years ago

I don't know enough about aspect oriented programming to answer your question, but I'll try to read about it and see how it applies to USBProxy.

elfring commented 10 years ago

Do you find information sources like the following useful?