search

usb-tools / USBProxy-legacy

A proxy for USB devices, libUSB and gadgetFS - this project is unmaintained, try here: https://github.com/usb-tools/Facedancer
GNU General Public License v2.0
433 stars 103 forks source link

Complete quoting for parameters of some CMake commands #8

Open elfring opened 10 years ago

elfring commented 10 years ago

Some parameters (like "${PROJECT_SOURCE_DIR}/cmake/modules" and "${CMAKE_CURRENT_BINARY_DIR}/usbproxy.pc") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

dominicgs commented 10 years ago

Oh dear, I've done that everywhere!

Thanks for catching this, my experience with CMake is minimal, so if you have any other tips/comments I would like to hear them.