usbarmory / tamago

TamaGo - ARM/RISC-V bare metal Go
BSD 3-Clause "New" or "Revised" License
1.35k stars 52 forks source link

imx6: Fix IOMUXC_END value #25

Closed cjams closed 3 years ago

cjams commented 3 years ago

The IOMUXC range ends at 0x020e3fff. Fix this from 0x0203ffff and change the range check in NewPad to use && instead of || to detect invalid addresses.

cjams commented 3 years ago

Found this issue while porting tamago to the SABRE lite board

abarisani commented 3 years ago

Thanks for spotting this!

abarisani commented 3 years ago

FYU: we sometimes set daisy to 0 when we do not use it, because of the correct check I see that we were handling this incorrectly and I resolved it in https://github.com/f-secure-foundry/tamago/commit/a2e021e0e2f60e39279c50696cf01936beef3225