usbong / UsbongStore

The "Usbong Store (Web)" is built using the Usbong eCOM Toolkit. It enables multiple merchants to offer their products via only one store *web* app.
0 stars 1 forks source link

Mobile Responsiveness: In Merchant page, Merchant category "TOYS & COLLECTIBLES" now occupies 2 rows #110

Closed masarapmabuhay closed 6 years ago

masarapmabuhay commented 6 years ago

Hi Zent, I hope you are doing well.

In the Merchant page, Merchant category "TOYS & COLLECTIBLES" now occupies 2 rows.

This occurs both in Google Chrome and Mozilla Firefox.

image

I have added an orange rectangle with rounded corners to help you understand what I mean.

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

It occupies 2 rows cause the content is long.

What seems to be the problem?

Thanks.

On Sun, Jul 29, 2018, 10:01 AM Masarap Mabuhay, notifications@github.com wrote:

Assigned #110 https://github.com/usbong/UsbongStore/issues/110 to @zent-lim https://github.com/zent-lim.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/110#event-1758729614, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplTxrCnFHRaGDlB_78IlD9SMosLiwUks5uLRdigaJpZM4VlQNh .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

Would you be able to make the "TOYS & COLLECTIBLES" occupy only 1 row?

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

I ll send u screen shot first.

I think if it will make it one row, the main section of the page will suffer (have less space).

Catch up w u the coming week! ☺

On Sun, Jul 29, 2018, 10:34 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

Would you be able to make the "TOYS & COLLECTIBLES" occupy only 1 row?

Thank you.

Peace, Mike

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/110#issuecomment-408647648, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT9LuknTIWexi5fraL1__tHOFWEjVks5uLR83gaJpZM4VlQNh .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply!

OK!

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

Re-aranging elements to resolve 111 coincidentally resolved this issue.

(1) zent repo 76bb9728f9897ecd6c20af2098a4741b65d9e685

(2) pull request: https://github.com/usbong/UsbongStore/pull/112

Kindly check if result is ok:

children

Afternoon!

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

Yes, I can confirm that your solution has indeed also resolved this issue.

This case is now closed.

Thank you.

Peace, Mike