usbong / UsbongStore

The "Usbong Store (Web)" is built using the Usbong eCOM Toolkit. It enables multiple merchants to offer their products via only one store *web* app.
0 stars 1 forks source link

Mobile Responsiveness: Misaligned text, fields, and button on the "Create New Account" page #119

Closed masarapmabuhay closed 6 years ago

masarapmabuhay commented 6 years ago

Hi Zent, I hope you are doing well.

May I kindly verify with you if our repository on GitHub already has your newest version of the Usbong Store code?

This is what I see on Firefox Quantum 62.0 (64-bit):

image

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Evebing Mike

I checked pull req below: https://github.com/usbong/UsbongStore/pull/118

Code is already in master repo.

Maybe kindly check the ff:

(1) is server using the code?

git log -10

The ff should appear (attached).

(2) is mobile responsive switch in core controller set to true?

(3) is core controller using latest version?

Have a good evening ahead :)

On Sun, Sep 23, 2018, 8:17 PM Masarap Mabuhay, notifications@github.com wrote:

Assigned #119 https://github.com/usbong/UsbongStore/issues/119 to @zent-lim https://github.com/zent-lim.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/119#event-1861960066, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT99ZGDZDUUCLunxmHgISfZvU9ejUks5ud3vGgaJpZM4W1raM .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

I have reverified the code on my local Windows server.

(1) I am already using the newest version from our Usbong Store repository on GitHub.

(2) Yes, the mobile responsiveness switch is set to TRUE.

(3) Yes, the core controller is the newest version.

The behaviour appears to be the same for both: 1) Firefox Quantum 62.0 (64-bit) 2) Microsoft Edge 40.15063.674.0 and Microsoft EdgeHTML 15.15063

Thank you.

Peace, Mike p.s. You seem to have not attached the file/screenshot you mention in your reply.

zent-lim commented 6 years ago

Hi Mike,

(1) Let me check in my env.

(2) Sorry. Here's the content of git log -10 or git log -15. The entry should appear towards the bottom:

commit 535d49a8c113d1ec27f042df067bb12ae671fa30 Author: Zent Lim zentlim@gmail.com Date: Wed Sep 12 14:16:15 2018 +0800 Added mobile responsive version of account/create.

Evening!

On Mon, Sep 24, 2018 at 8:33 PM Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

I have reverified the code on my local Windows server.

(1) I am already using the newest version from our Usbong Store repository on GitHub.

(2) Yes, the mobile responsiveness switch is set to TRUE.

(3) Yes, the core controller is the newest version.

The behaviour appears to be the same for both:

  1. Firefox Quantum 62.0 (64-bit)
  2. Microsoft Edge 40.15063.674.0 and Microsoft EdgeHTML 15.15063

Thank you.

Peace, Mike p.s. You seem to have not attached the file/screenshot you mention in your reply.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/119#issuecomment-423958835, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT4IuhIGMSQaIsiZyiW_t1EyflpcMks5ueNELgaJpZM4W1raM .

zent-lim commented 6 years ago

Good Day Mike,

(1) The commit below seem to have damaged the repo.

  commit fedb5d3b9e8897d8bf5c955e9ae17bfce86b04f4

  Author: Michael B. Syson <masarapmabuhay@gmail.com>

  Date:   Sun Sep 16 20:30:19 2018 +0800

  Note: +fixed: when Mobile Responsiveness setting is set to TRUE,

incorrect product item count displayed on the cart icon of Mobile Responsive pages

(2) Particularly, core controller function initHeader() was damaged.

 Damaged Version:

https://github.com/usbong/UsbongStore/blob/fedb5d3b9e8897d8bf5c955e9ae17bfce86b04f4/usbong_store/application/core/MY_Controller.php

 Stable Version (1 commit earlier of Damaged Version):

https://github.com/usbong/UsbongStore/blob/daffa9c467f149d8b16bbe9917e75e33edfefbae/usbong_store/application/core/MY_Controller.php

(3) Please see the url in Stable Version.

Lines 144 to 176 in Stable Version is incomplete in Damaged Version

(lines 127 to 142).

Around 10 lines disappeared in Damaged Version.

Have a good evening ahead.

On Mon, Sep 24, 2018 at 9:16 PM Zent Lim zentlim@gmail.com wrote:

Hi Mike,

(1) Let me check in my env.

(2) Sorry. Here's the content of git log -10 or git log -15. The entry should appear towards the bottom:

commit 535d49a8c113d1ec27f042df067bb12ae671fa30 Author: Zent Lim zentlim@gmail.com Date: Wed Sep 12 14:16:15 2018 +0800 Added mobile responsive version of account/create.

Evening!

On Mon, Sep 24, 2018 at 8:33 PM Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

I have reverified the code on my local Windows server.

(1) I am already using the newest version from our Usbong Store repository on GitHub.

(2) Yes, the mobile responsiveness switch is set to TRUE.

(3) Yes, the core controller is the newest version.

The behaviour appears to be the same for both:

  1. Firefox Quantum 62.0 (64-bit)
  2. Microsoft Edge 40.15063.674.0 and Microsoft EdgeHTML 15.15063

Thank you.

Peace, Mike p.s. You seem to have not attached the file/screenshot you mention in your reply.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/119#issuecomment-423958835, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT4IuhIGMSQaIsiZyiW_t1EyflpcMks5ueNELgaJpZM4W1raM .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

I've fixed the so-called "damaged" files based on your Stable Version. Here is my newest commit and push to the Usbong Store repository: https://github.com/usbong/UsbongStore/commit/418af47d9dd7bcbefe8c325b8f100fae12721558

Result: 1) The issue seems to be resolved on Firefox Quantum.

image

2) In Microsoft Edge, however, this is what I see.

image

May I kindly ask if you can verify if the behavior on Google Chrome is the same with Firefox Quantum? Or, is it the same with Microsoft Edge?

Would you be able to resolve the issue for the other browser/s as well?

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Morning Mike,

Thank you for the update.

(1) Firefox looks good in the latest push.

(2) Chrome looks ok also.

chromexs

(3) Currently, I dont have the tech stack to run Windows Edge.

  (a) Can we schedule a work meet after October 9? 

  (b) Based on quirk searches though, Edge seem to be buggy (so even if we meet, there s a decent chance we cant fix it):

        https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/13962174/

        https://github.com/twbs/bootstrap/issues/25309

        https://stackoverflow.com/questions/37683629/ie-ms-edge-links-in-bootstrap-col-not-working-on-page-load

   (c) Additionally, user base seem small (but not certain):

        https://www.computerworld.com/article/3242165/microsoft-windows/microsofts-edge-browser-is-in-serious-trouble.html 

Thanks.

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

(1) OK.

(2) OK.

(3) (a) Yes, we can schedule a meetup after Oct. 9. (b) OK. (c) OK.

--> I realized that we'll also have to verify whether the issue occurs on the Safari browser.

Action Item: 1) Verify if the issue also occurs on the Safari browser --> Owner: Mike --> Finish: Sept. 29, 2018 (Sat)

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Okly dokly Mike,

Catch up w u when i get back after oct 9. :)

Thanks! :)

On Fri, Sep 28, 2018, 8:35 PM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

(1) OK.

(2) OK.

(3) (a) Yes, we can schedule a meetup after Oct. 9. (b) OK. (c) OK.

--> I realized that we'll also have to verify whether the issue occurs on the Safari browser.

Action Item:

  1. Verify if the issue also occurs on the Safari browser --> Owner: Mike --> Finish: Sept. 29, 2018 (Sat)

Thank you.

Peace, Mike

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/119#issuecomment-425421561, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT6JDE8wCDqfI6CoIubrwzOlsZmH-ks5ufheXgaJpZM4W1raM .

masarapmabuhay commented 6 years ago

Hi Zent, I hope you are doing well.

I have verified that the issue also occurs on a Safari browser (Version 11.1.2 (12605.3.8.1)).

image

I shall keep this issue open.

In the meantime, I'll proceed to verifying the other pages for Usbong Store: Mobile Responsiveness (Phase 3).

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

Thank you for the info.

No luck on my end finding a way to run safari.

The closest one was an onld version, but the thread below says it wont run anymore: https://askubuntu.com/questions/585209/opera-and-safari-installation

Let's add this agenda to our work session after OCt 9.

Thank you!

On Sat, Sep 29, 2018 at 1:22 PM Masarap Mabuhay notifications@github.com wrote:

Hi Zent, I hope you are doing well.

I have verified that the issue also occurs on a Safari browser (Version 11.1.2 (12605.3.8.1)).

[image: image] https://user-images.githubusercontent.com/344066/46241344-25dffd00-c3ea-11e8-9d59-93accd733833.png

I shall keep this issue open.

In the meantime, I'll proceed to verifying the other pages for Usbong Store: Mobile Responsiveness (Phase 3).

Thank you.

Peace, Mike

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/119#issuecomment-425617188, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplTz4os-_T-zbnVwUc3E4Sul3II4hTks5ufwN5gaJpZM4W1raM .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply!

Let me now reply to your reply with an OK and a thank you!

Peace, Mike p.s. it took me 3 days to reply to you though, which isn't our usual standard of 2 business days.

zent-lim commented 6 years ago

Okly dokly! Thanks for having me over! :)

On Tue, Oct 16, 2018 at 8:56 PM Masarap Mabuhay notifications@github.com wrote:

Closed #119 https://github.com/usbong/UsbongStore/issues/119.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/119#event-1906723531, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT1JYUbVuaBbUrCv7RmYMblu7gn0jks5uldeKgaJpZM4W1raM .