Mobile Responsiveness: in product item page, after clicking "ADD TO CART", font size and color of text in pop-up window is smaller and of a lighter shade

[masarapmabuhay]

Hi Zent, I hope you are doing well.

I am presently doing QA (Quality Assurance) of Usbong Store (Mobile Responsiveness) Phase 3: Milestone 4: w.

Observation: In the product item page, after clicking "ADD TO CART", the font size and color of the text in the pop-up window is smaller and of a lighter shade.

1) Mobile Responsive version:

2) Non-mobile Responsive version:

Would you be able to update the font size and color to match with the Non-mobile Responsive version's?

Thank you.

Peace, Mike

[zent-lim]

Good Day Mike,

This was done intentionally as the new version is aesthetically better in my opinion.

Are you sure you'd like to use the font size and font color from the old version?

If yes, no problem.

I would simply like to double confirm.

Have a good day ahead.

On Wed, Oct 24, 2018 at 10:42 AM Masarap Mabuhay notifications@github.com wrote:

Hi Zent, I hope you are doing well.

I am presently doing QA (Quality Assurance) of Usbong Store (Mobile Responsiveness) Phase 3: Milestone 4: w.

Observation: In the product item page, after clicking "ADD TO CART", the font size and color of the text in the pop-up window is smaller and of a lighter shade.

1.

Mobile Responsive version: [image: image] https://user-images.githubusercontent.com/344066/47402432-1ef1a380-d778-11e8-8f45-1628b3cbd11f.png 2.

Non-mobile Responsive version: [image: image] https://user-images.githubusercontent.com/344066/47402502-8576c180-d778-11e8-8fee-1e576e988727.png

Would you be able to update the font size and color to match with the Non-mobile Responsive version's?

Thank you.

Peace, Mike

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/123, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT2XsmqRmEYXivS60dmu2C-bvyIqVks5un9OZgaJpZM4X3BI0 .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

Yes, let's use the font size and color in the Non-mobile responsive version.

The larger font size and the darker shade make it easier for me to read the text.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

Thank you for confirming the direction.

(1) I executed your request in:

commit 77debcc0d1ebdb376af97e831296b1f133333f18

Author: Zent Lim zentlim@gmail.com

Date: Thu Oct 25 15:58:03 2018 +0800

Note: Resolved issue 123.

(2) I sent a pull request in:

https://github.com/usbong/UsbongStore/pull/125

Have a good day ahead!

[masarapmabuhay]

Hi Zent, I hope you are doing well.

OK. I have verified your update.

I increased the font size we use for the product item name.

I have committed and pushed my update here: https://github.com/usbong/UsbongStore/commit/e1fd263f6e709f6985933add86564c28844159a9

This issue is now closed.

If you disagree, please simply re-open it.

Thank you.

Peace, Mike

[zent-lim]

Okly dokly Mike,

No problem. ☺

Thank you for the update.

On Sat, Oct 27, 2018, 10:28 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, I hope you are doing well.

OK. I have verified your update.

I increased the font size we use for the product item name.

[image: image] https://user-images.githubusercontent.com/344066/47598721-e568a480-d9d2-11e8-884f-aadbd7fb7929.png

I have committed and pushed my update here: e1fd263 https://github.com/usbong/UsbongStore/commit/e1fd263f6e709f6985933add86564c28844159a9

This issue is now closed.

If you disagree, please simply re-open it.

Thank you.

Peace, Mike

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/123#issuecomment-433583873, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT92LNQwXAJG05Ar2lj-hLlph-C8Uks5uo8THgaJpZM4X3BI0 .