usbong / UsbongStore

The "Usbong Store (Web)" is built using the Usbong eCOM Toolkit. It enables multiple merchants to offer their products via only one store *web* app.
0 stars 1 forks source link

Mobile Responsiveness: in product item page, after clicking "ADD TO CART", pop-up window is displayed at the center (horizontally) of the screen #124

Open masarapmabuhay opened 6 years ago

masarapmabuhay commented 6 years ago

Hi Zent, I hope you are doing well.

I am presently doing QA (Quality Assurance) of Usbong Store (Mobile Responsiveness) Phase 3: Milestone 4: w.

Observation: In the product item page, after clicking "ADD TO CART", the pop-up window is displayed at the center (horizontally) of the screen.

1) Mobile Responsive version: image

2) Non-mobile Responsive version: image

Would you be able to update the location of the pop-up window such that it is at the top-right portion of the screen, just below the uplifting apps row, instead of at the center (horizontally)?

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

(1) Putting it on the upper right side will not render correctly on smaller screens.

As such I dont think the bootstrap component used will support that function.

For more info about the component used, please see: https://getbootstrap.com/docs/3.3/javascript/#modals

(2) Additionally, the center placement looks better from a design perspective (in my point of view only).

Have a good day ahead.

On Wed, Oct 24, 2018 at 10:54 AM Masarap Mabuhay notifications@github.com wrote:

Assigned #124 https://github.com/usbong/UsbongStore/issues/124 to @zent-lim https://github.com/zent-lim.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/124#event-1922228949, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplTyPNWlyki-YlHBl-eL2Nx0LZSxWPks5un9ZRgaJpZM4X3BxZ .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

OK. Let me read the information about the component we are using.

In the meantime, I have put this issue to a lower severity.

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Okly dokly Mike,

Have a good day ahead!

On Wed, Oct 24, 2018 at 4:28 PM Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

OK. Let me read the information about the component we are using.

In the meantime, I have put this issue to a lower severity.

Thank you.

Peace, Mike

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/124#issuecomment-432561962, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT9-NgihsEsF_AjPLpMCG6hOLMHzjks5uoCSVgaJpZM4X3BxZ .