There are Five Head and Body Tags on Home Page

[zent-lim]

Hi MIke,

I was using your home page template structure as base structure for Auto Email Milestone 4.

The html seems to be broken. There are five head and body tags.

To check: (1) please open home page using browser (2) right click (3) click "View Page Source"

I saw the following:

(1) empty body tag after inline css (2) another body tag for header (3) another body tag for image offers (4) another body tag for home page content (5) another body tag for footer

I'll do my best to proceed with milestone 4.

Please verify if this problem is valid.

If yes, kindly also notify if fix is ready.

Thanks lots!

[masarapmabuhay]

Hi Zent, Thank you for the question.

Can you send me the link to the pertinent file, so that I may be able to diagnose it more properly?

I also use templates for the header, footer, etc. https://github.com/usbong/UsbongStore/tree/master/usbong_store/application/views/templates

Please let me know if this answers your question.

Thank you!

Peace, Mike

[zent-lim]

Evening Mike,

The files that are suspect to the problem are the files you sent over under the template dir.

All of them have html, head, and body tags.

I think only one of them should have these tags. Most likely, only the outermost template.

Thank you.

On Oct 11, 2017 3:55 PM, "Masarap Mabuhay" notifications@github.com wrote:

Hi Zent, Thank you for the question.

Can you send me the link to the pertinent file, so that I may be able to diagnose it more properly?

I also use templates for the header, footer, etc. https://github.com/usbong/UsbongStore/tree/master/ usbong_store/application/views/templates

Please let me know if this answers your question.

Thank you!

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-335719825, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT6UZhZnTMJx6n0qIc6b3IGNQ58sCks5srHSCgaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, Thank you for the reply!

Yes, you are correct.

All the template files have html, head, and body tags.

They aren't throwing any errors in prod and local though.

May I ask what errors they are producing in your setup?

Thank you.

Peace, Mike

[zent-lim]

HI Mike,

(1) The html syntax is wrong. Browser flags it as error by highlighting it in red. As consequence, jquery might not be able to parse your DOM correctly.

​

(2) Although I'm unsure at this point, I think this is one of several reasons why your layout breaks when screen size is mobile:

​

Evening!

On Wed, Oct 11, 2017 at 7:21 PM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply!

Yes, you are correct.

All the template files have html, head, and body tags.

They aren't throwing any errors in prod and local though.

May I ask what errors they are producing in your setup?

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-335778224, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT2eYM6rqgtG2bVlIiCvey-bv8_BRks5srKSggaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

In that case, I'll have to do code refactoring to remove the unnecessary tags.

I am slowly, but surely learning proper web development.

Thank you!

Peace, Mike

[zent-lim]

Cool!

Feel free to buzz as needed 😁

On Oct 12, 2017 7:50 AM, "Masarap Mabuhay" notifications@github.com wrote:

Hi Zent, Thank you for the reply.

In that case, I'll have to do code refactoring to remove the unnecessary tags.

I am slowly, but surely learning proper web development.

Thank you!

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-335980448, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplTwpw6D8q4_kGgeP1WYWt6DAXdaqZks5srVRbgaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, I was able to remove all unnecessary html, head, and body tags as you advised. The Usbong Store remains functioning as it should.

I have committed the updated code on our GitHub repo.

Please verify if the error flags you encountered still persist.

Thank you.

Peace, Mike

[zent-lim]

Evening Mike,

Thanks for the update. It's a step closer in the right direction.

The new commit has the ff problems:

(1) There are multiples instances of "<!DOCTYPE html>". Browser reports it as problem. Please see attached file DocType.png.

(2) There is a malformed div near the login header. Please see div highlighted in red. It should not have a quotation mark. Please see attached file Login.png.

P.S. Unfortunately, even with this fix, layout still breaks in small screens.

On Thu, Oct 12, 2017 at 12:57 PM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, I was able to remove all unnecessary html, head, and body tags as you advised. The Usbong Store remains functioning as it should.

I have committed the updated code on our GitHub repo.

Please verify if the error flags you encountered still persist.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-336020828, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT2vt6L3nnKG9ECrXhIDgcbBciwEPks5srZxNgaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK! I will apply the necessary changes then.

In the meantime, can you resend the attached files you mentioned? It seems that you weren't able to include them in your message.

Thank you.

Peace, Mike p.s. for mobile devices, we recommend using the Usbong Store App (http://app.usbong.ph).

[zent-lim]

Hi MIke,

I think github removes attachment.

I'll try to place the images inline. Please inform if not visible from your end.

(1) Doctype Problem

​

(2) Logo Problem

​ Thank you!

P.S. There is only 1 major UI left for milestone four. 😃

On Fri, Oct 13, 2017 at 8:00 AM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

OK! I will apply the necessary changes then.

In the meantime, can you resend the attached files you mentioned? It seems that you weren't able to include them in your message.

Thank you.

Peace, Mike p.s. for mobile devices, we recommend using the Usbong Store App ( http://app.usbong.ph).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-336313419, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplTxPz-wf260yFyHg2MBmCxkY6gRYRks5srqgVgaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

Yes, you are correct.

The images are not shown on my end here on GitHub. Even the auto-email I received via GitHub did not include the images.

Perhaps, it's best that for messages with images, you email them to me. I understand that this is what you are already doing.

Thank you.

Peace, Mike

[zent-lim]

Morning Mike!

I resent the pics to your email.

Morning!

On Thu, Nov 30, 2017 at 7:39 PM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

Yes, you are correct.

The images are not shown on my end here on GitHub. Even the auto-email I received via GitHub did not include the images.

Perhaps, it's best that for messages with images, you email them to me. I understand that this is what you are already doing.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-348164189, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT__SrGBGHLlNDlyBFlbMmv1SWuLtks5s7pPpgaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, I have finally reviewed this issue again, and have checked the images you sent to me via email.

1) Doctype Problem --> According to W3 Schools,

Tip: Always add the <!DOCTYPE> declaration to your HTML documents, so that the browser knows what type of document to expect.

It may be possible that your bug indicator is incorrect?

Software/Machines can and do malfunction, although we do our best to minimize defects.

2) Logo Problem --> I was able to address this in one of my code updates.

Please let me know if you agree with my resolution to 1), so that I can already close this issue.

Thank you.

Peace, Mike p.s. based on my experience working with you, your performance, e.g. technical support, has been quite commendable, that is to say, uplifting. I hope you may continue to be such splendid company.

[zent-lim]

Evening Mike!

In latest version, I still see five DOCTYPE declarations for home page.

I'd recommend this to be placed low prio though.

I don't think there are immediate consequences for this.

(1) Version

commit d67f5fa7825c860403c1ab4f44d86fe29ed2722e Author: Michael Syson masarapmabuhay@gmail.com Date: Mon Dec 25 15:48:01 2017 +0800

+updated: contact page
--> fixed: typo's
--> added: when "support (at) usbong (dot) ph" is clicked,

automatically open Microsoft Outlook if available, or Apple mail with the email

(2) Below are files that declare DOCTYPE under UsbongStore/usbong_store/application/views.

./contact.php:?><!DOCTYPE html> ./b/miscellaneous.php:?><!DOCTYPE html> ./b/frontPage.php:?><!DOCTYPE html> ./b/textbooks.php:?><!DOCTYPE html> ./b/beverages.php:?><!DOCTYPE html> ./b/books.php:?><!DOCTYPE html> ./b/comics.php:?><!DOCTYPE html> ./b/toys_and_collectibles.php:?><!DOCTYPE html> ./b/promos.php:?><!DOCTYPE html> ./b/childrens.php:?><!DOCTYPE html> ./b/literature_and_fiction.php:?><!DOCTYPE html> ./b/food.php:?><!DOCTYPE html> ./b/manga.php:?><!DOCTYPE html> ./shoppingcart.php:?><!DOCTYPE html> ./thankyou.php:?><!DOCTYPE html> ./welcome_message.php:?><!DOCTYPE html> ./checkout.php:?><!DOCTYPE html> ./account/ordersummaryadmin.php:?><!DOCTYPE html> ./account/requestsummaryadmin.php:?><!DOCTYPE html> ./account/orderdetailsmerchant.php:?><!DOCTYPE html> ./account/login.aspx:?><!DOCTYPE html> ./account/customersummaryadmin.php:?><!DOCTYPE html> ./account/create.php:?><!DOCTYPE html> ./account/ordersummary.php:?><!DOCTYPE html> ./account/customerdetailsadmin.php:?><!DOCTYPE html> ./account/settings.php:?><!DOCTYPE html> ./account/sellsummaryadmin.php:?><!DOCTYPE html> ./account/orderdetailsadmin.php:?><!DOCTYPE html> ./account/login.php:?><!DOCTYPE html> ./account/settingsmerchant.php:?><!DOCTYPE html> ./account/orderdetails.php:?><!DOCTYPE html> ./account/searchhistoryadmin.php:?><!DOCTYPE html> ./account/updatepassword.php:?><!DOCTYPE html> ./account/carthistoryadmin.php:?><!DOCTYPE html> ./account/ordersummarymerchant.php:?><!DOCTYPE html> ./home.php:?><!DOCTYPE html> ./auto-email/email_frame_simple_template.php:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" " http://www.w3.org/TR/html4/loose.dtd"> ./errors/html/error_404.php:?><!DOCTYPE html> ./errors/html/error_general.php:?><!DOCTYPE html> ./errors/html/index.html:<!DOCTYPE html> ./errors/html/error_db.php:?><!DOCTYPE html> ./errors/index.html:<!DOCTYPE html> ./errors/cli/index.html:<!DOCTYPE html> ./privacy.php:?><!DOCTYPE html> ./browse.php:?><!DOCTYPE html> ./request.php:?><!DOCTYPE html> ./templates/general_template.php:?><!DOCTYPE html> ./templates/style.php:?><!DOCTYPE html> ./templates/right_side_bar.php:?><!DOCTYPE html> ./templates/footer.php:?><!DOCTYPE html> ./templates/header.php:?><!DOCTYPE html> ./terms.php:?><!DOCTYPE html> ./sitesecurity.php:?><!DOCTYPE html> ./w.php:?><!DOCTYPE html> ./sell.php:?><!DOCTYPE html> ./help.php:?><!DOCTYPE html> ./index.html:<!DOCTYPE html>

(3) You likely only need it for the ff:

 (a) /templates/header.php

 (b) all pages that don't use /templates/header.php and render

individually, below are examples but i'm not 100% certain

      - auto-email/email_frame_simple_template.php

      - errors/html/error_*.php

Have a good day ahead!

P.S. Cool! Looking forward to writing more code. Have a good evening ahead!

Got a head start for phase 3. JS component of picture cut looks integrated. Will explore compatibility further.

On Tue, Dec 26, 2017 at 1:00 PM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, I have finally reviewed this issue again, and have checked the images you sent to me via email.

1. Doctype Problem --> According to W3 Schools https://www.w3schools.com/tags/tag_doctype.asp,

Tip: Always add the <!DOCTYPE> declaration to your HTML documents, so that the browser knows what type of document to expect.

It may be possible that your bug indicator is incorrect?

Software/Machines can and do malfunction, although we do our best to minimize defects.

1. Logo Problem --> I was able to address this in one of my code updates.

Please let me know if you agree with my resolution to 1), so that I can already close this issue.

Thank you.

Peace, Mike p.s. based on my experience working with you, your performance, e.g. technical support, has been quite commendable, that is to say, uplifting. I hope you may continue to be such splendid company.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-353917950, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT6u4wzfvr1MnHJvw8nkxMUWk3V9Uks5tEH15gaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK! Yes, it may be as you say, only the header file would need <!DOCTYPE html>, since the other files would include the header file already.

Let me go with your advice of putting this in low priority for now, and address it later on.

Have a wonderful day as well, even though the weather may seem bleak.

Sometimes, the smell of freshly brewed coffee can raise people's spirits. Or perhaps, drinking Earl Grey tea, while eating something sweet!

Peace, Mike p.s. OK! Thank you. "Observe, Learn, Make It Your Own!"

[zent-lim]

Hi Mike,

=========== UPDATE

I identified (probably) one of the biggest reasons why layout breaks.

The file below was not written to be mobile responsive:

UsbongStore/usbong_store/application/views/templates/right_side_bar.php

=========== QUICK FIX:

(1) Hide the non compliant html code when layout breaks.

(2) The layout breaks on screen size md. Here's what it looks like on md:

(3) Here's code for a quick fix (although several other components still break):

ORIG:

    <div class="Image-offers">    

TEMP FIX:

    <div class="Image-offers hidden-xs hidden-sm hidden-md vissible-lg">

=========== LONG TERM FIX:

(1) We basically need to rewrite the front end as prescribed by bootstrap spec:

https://getbootstrap.com/docs/3.3/css/#grid

Usbong Store uses bootstrap to make things mobile responsive. But in several segments, it was not used making the layout break.

(2) The problem here is that the front end has a lot of javascript tied to it.

Overhauling the front end may damage these js.

=========== QUESTION:

How would you like to proceed?

(1) If you go for the long term fix, I recommend I handle the html and you handle the js.

(2) Not only will we have to edit view side, controller side also needs to be updated. We need to reorganize how the templates are nested to form a whole view.

Have a good day ahead!

[masarapmabuhay]

Hi Zent, Thank you for the reply.

May I kindly ask what is your estimated time of completion to accomplish this task?

We may be optimizing for the front-end on something that may be nice to have, but wouldn't be regularly used.

Perhaps, it may be simpler to set the layout to non-auto-responsive for now, and work on the other tasks for Phase 5.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike

I havnt looked into the other problems yet. But for this problem alone, i estimating 2 weeks min part time excluding js.

No prob on postponing.

As long as u are making sales w the current front end that u have.

Ill estimate phase 5 (back end) by mid nxt week then.

Catch up w u soon! ☺

On Mar 12, 2018 2:36 PM, "Masarap Mabuhay" notifications@github.com wrote:

Hi Zent, Thank you for the reply.

May I kindly ask what is your estimated time of completion to accomplish this task?

We may be optimizing for the front-end on something that may be nice to have, but wouldn't be regularly used.

Perhaps, it may be simpler to set the layout to non-auto-responsive for now, and work on the other tasks for Phase 5.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-372206788, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT59vMXzh0F3qKKLj-7htbwerfvfQks5tdheAgaJpZM4P1BB9 .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK!

In the meantime, please send me your estimate for Phase 5 as soon as it's available.

Thank you.

Peace, Mike

[zent-lim]

Catch up w u mid next week Mike.

I ll also see if i can speed up the estimates. This week is full. So i queued usbong stuff ahead (front end check, text area problem). 😁

On Mar 12, 2018 2:58 PM, "Masarap Mabuhay" notifications@github.com wrote:

Hi Zent, Thank you for the reply.

OK!

In the meantime, please send me your estimate for Phase 5 as soon as it's available.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/8#issuecomment-372210222, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT_8AWG3HTb79oeUpjMrchUTiERasks5tdhyUgaJpZM4P1BB9 .

[masarapmabuhay]

OK, Zent! Thank you!

Peace, Mike