usbong / UsbongStore

The "Usbong Store (Web)" is built using the Usbong eCOM Toolkit. It enables multiple merchants to offer their products via only one store *web* app.
0 stars 1 forks source link

Auto-email: Unable to save work-in-progress data #83

Open masarapmabuhay opened 6 years ago

masarapmabuhay commented 6 years ago

Hi Zent, I am doing Unit-Testing of auto-email. I noticed that I am unable to save work-in-progress data.

Usbong Store's Auto-email component is saying the following:

Warning! Please fill up Set Data first.

Does this mean that I have to completely fill-up all the data first? If yes, "Open Draft Email" would be irrelevant?

Thank you.

Peace, Mike p.s. this behavior seems to occur in all auto-email templates.

zent-lim commented 6 years ago

Hi Mike

(1) Auto email creation is done in stages.

Template, data, products

The message u said appears is u go to tge later step without conoleting the prerequisite step

(2) you can still use the open draft email feature.

Just fill in the data in the required steps, one step at a time.

Any time ù abort a step, u can use the open draft email feature.

Morning!

On Sun, Mar 25, 2018, 9:18 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, I am doing Unit-Testing of auto-email. I noticed that I am unable to save work-in-progress data.

Usbong Store's Auto-email component is saying the following:

Warning! Please fill up Set Data first.

Does this mean that I have to completely fill-up all the data first? If yes, "Open Draft Email" would be irrelevant?

Thank you.

Peace, Mike p.s. this behavior seems to occur in all auto-email templates.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/83, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT38u9TedzQ721NFsOxD_K3wUGm5mks5thvBqgaJpZM4S5-DO .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

It seems that I have to click the "Next" button for the data to actually save.

When I only click the SAVE link, even if I've filled up all the data for that page, the Auto-email component doesn't save the data.

Would you agree to enable the SAVE link to function similar to the "Next" button in that it would also store the data in the DB, but without transferring to the next page or step?

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike

On Sun, Mar 25, 2018, 10:46 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

It seems that I have to click the "Next" button for the data to actually save.

Yes

When I only click the SAVE link, even if I've filled up all the data for that page, the Auto-email component doesn't save the data.

Yes

Would you agree to enable the SAVE link to function similar to the "Next" button in that it would also store the data in the DB, but without transferring to the next page or step?

I wouldnt recommend that cause the save link can be accessed from anywhere whereas the the next button can only be accessed when the prerequisite form is present (user filling up data).

Morning!

Thank you.

Peace, Mike

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/83#issuecomment-375941126, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT-IZjDEOOwiAI-u1wRBbP6gXefZ5ks5thwUMgaJpZM4S5-DO .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

If the prerequisite form and the "Next" button are present, shouldn't the SAVE link also actually "save" or store data?

May I kindly ask where else the SAVE link is present, such that it shouldn't "save" as it should?

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

(1) The SAVE link does contain a save button. Please see the green button in the image below.

save

(2) Below are urls that contain the save link:

https://store.usbong.ph/index.php/auto-email/resume

https://store.usbong.ph/index.php/auto-email/create/data

https://store.usbong.ph/index.php/auto-email/edit/data/XXX

https://store.usbong.ph/index.php/auto-email/create/products/1

Morning!

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

In that case, if there is a "Save" button, may I kindly ask what the SAVE link is for?

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

The save link is a tab that summarizes all the data before the user commits it to the database.

Morning!

On Mon, Mar 26, 2018, 10:27 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

In that case, if there is a "Save" button, may I kindly ask what the SAVE link is for?

Thank you.

Peace, Mike

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/83#issuecomment-376028812, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplTy_32QCRTA_rKlkr3SlgzGhk_vsfks5tiFIDgaJpZM4S5-DO .

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

May I kindly ask what you mean by "summarizes all the data"?

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

Please see image below: save

It lists all your data and asks you if you'd like to proceed with the save.

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the reply.

Does that mean that the SAVE link will only function if all the fields have data? Therefore, it functions like a quick link to the summary page.

Unfortunately, it appeared to me that it was supposed to function like the "Save" button.

Having said this, "Open Draft Email" now seems unnecessary.

Please correct me if my understanding is wrong.

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

On Mon, Mar 26, 2018 at 3:17 PM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

Does that mean that the SAVE link will only function if all the fields have data? Therefore, it functions like a quick link to the summary page.

Yes. If data is incomplete, it will prompt you to complete the data.

Unfortunately, it appeared to me that it was supposed to function like the "Save" button.

It opens that page containing the Save button.

Having said this, "Open Draft Email" now seems unnecessary.

Could you explain why?

Thanks!

Please correct me if my understanding is wrong.

Thank you.

Peace, Mike

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/83#issuecomment-376069054, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT7A_Dav1n7HFEiEIf130jY_l4wA9ks5tiJYWgaJpZM4S5-DO .

zent-lim commented 6 years ago

Hi Mike,

This look back at why you had the feature ordered might help you remember your whys: https://github.com/usbong/UsbongStore/issues/65

(1) Prior to this update, "Open Draft Email" was already available.

It was placed under label "+Create New Email".

If the auto email feature detects an incompletely created email, it will load the cache with the last data automatically.

You wanted the cache to clear. But at the same time preserve the existing functionality.

(2) You then requested that you wanted two buttons: "+Create New Email" and "+Open Draft Email"

Mike: "If that is the case, may I ask what would be your recommendation given that when there exists saved data, "+Create New Email", is more of "+Open Draft Email"? Would adding another button be simpler?"

(3) I then said, I recommend the status quo - no change.

Zent: "I recommend the status quo - preserve the draft data. (1) This was done by design so that the user does not have to retype everything should he decide to continue where he left off. (2) Please also note that the draft data is on a per user basis. - Another user can not see another user's draft data - When a user signs out, the draft data disappears with it."

(4) I then asked which direction you preferred. You said you prefer two separate buttons.

Mike: "Would you agree to add another button for "+Open Draft Email", so that there will be two buttons? This is so that the client can choose to create a new email or load a draft email."

This was why you wanted "+Create New Email" to be separate from "+Open Draft Email".

When you choose "+Create New Email", all cache is cleared as you requested.

I hope that reminds you on why you requested for the additional button.

Have a good day ahead!

masarapmabuhay commented 6 years ago

Hi Zent, Thank you for the replies.

1) Yes, if the merchant/client doesn't fill up all the fields, the Auto-email component will display a message prompting him/her to "Set Data" first. --> I noticed, however, that if Auto-email hasn't yet stored the data into the DB, he/she will have to fill up all the fields again from the start.

2) OK. Yes, the Auto-email component opens the page containing the "Save" button.

3) As for the "Open Draft Email", if Auto-email has already stored the data of the email, the merchant/client can simply click the "Edit Email" button in the Auto-email (Admin) page. --> At present, the "Open Draft Email" seems to function more along the lines of "Edit Email", but only for the first email on the list. --> I was under the impression that "Open Draft Email" would be used for work-in-progress emails, such as those whose data Auto-email hasn't yet stored into the DB.

Please never hesitate to correct me if my understanding is wrong.

Thank you.

Peace, Mike

zent-lim commented 6 years ago

Hi Mike,

On Tue, Mar 27, 2018 at 8:26 AM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the replies.

1.

Yes, if the merchant/client doesn't fill up all the fields, the Auto-email component will display a message prompting him/her to "Set Data" first. --> I noticed, however, that if Auto-email hasn't yet stored the data into the DB, he/she will have to fill up all the fields again from the start.

No.

That's not how it works.

It allows the user to continue where you he has left off.

What is your test scenario?

1. 2.

OK. Yes, the Auto-email component opens the page containing the "Save" button. 3.

As for the "Open Draft Email", if Auto-email has already stored the data of the email, the merchant/client can simply click the "Edit Email" button in the Auto-email (Admin) page. --> At present, the "Open Draft Email" seems to function more along the lines of "Edit Email", but only for the first email on the list.

No. It functions as an edit for one unsaved entry.

1.

--> I was under the impression that "Open Draft Email" would be used for work-in-progress emails, such as those whose data Auto-email hasn't yet stored into the DB.

Yes. That's how it works.

It allows the user to continue creating an email that is not yet saved in database.

Have a good day ahead.

1.

Please never hesitate to correct me if my understanding is wrong.

Thank you.

Peace, Mike

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/83#issuecomment-376355209, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT9DuhLquR_kB5rw1huAfNPCpY10lks5tiYcngaJpZM4S5-DO .