Product Management: in product overview, existing links, <br> tags, etc are removed

[masarapmabuhay]

Hi Zent, I was verifying the new text editor you added for product overview.

I noticed that existing links (as well as any other tags, e.g. <br>) are removed.

Could it be because this feature doesn't support backward compatibility?

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

Please send me a screen shot of what you mean.

I checked just now and html tags are properly placed.

Have a good day ahead!

[masarapmabuhay]

Hi Zent, Thank you for the reply.

This is what I mean:

The text in the product overview has lost its formatting.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

I checked cms side yesterday also and it looked ok. I will send screenshot when i get access to laptop.

(1) Could you send though the product overview data from ur phpmyadmin? (W br tags and a tags from old formatting)

Mine already uses the new data after i used the new feature.

(2) I will use your data to test for backward compatibility.

(3) I suspect though that if its indeed not backward compatible, the best thing to do is leave it as is.

Because: it will not affect what the user sees in front end.

You can use the new feature for future items and the old formatting data for old items.

Morning!

On Sun, Apr 8, 2018, 8:39 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

This is what I mean:

[image: image] https://user-images.githubusercontent.com/344066/38461632-0fa44c78-3b08-11e8-9d6a-87ed75dd5e1b.png

The text in the product overview has lost its formatting.

Thank you.

Peace, Mike

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/87#issuecomment-379509516, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplTzjSPBeHHkaiiabCKHADoNYzhkEZks5tmVw4gaJpZM4TK2Wz .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK. Here is the value of product_overview from phpmyadmin.

Story by Augie Rivera<br>
Illustrations by Kora Dandan-Albano<br>
<br>
This is an original story on the legend of the bitter gourd. The story excites the imagination of children and warns them against the evil of envy and greed.
<br><br>
Isang orihinal na kuwento tungkol sa alamat ng ampalaya, pinupukaw nito ang imahinasyon ng mga bata at binabalaan sila sa kasamaang dulot ng pagkainggit at kasakiman.
<br><br>
Finalist – 1995 PBBY-Salanga Prize

While we should make Usbong Store backward compatible, if we cannot do so, could we at least be able to identify if it's using the old format or the new one?

There may be clients who'd want to dabble with phpmyadmin when updating their online stores.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

Thanks for sending test data.

(1) I have confirmed your assumption. The new admin module for product overview UI can not read the old format correctly. Both br and anchor tags disappear. Here's what the admin ui looks like when it loads old format:

(a) Test Data:

Story by Augie Rivera<br>
Illustrations by <a href="https://www.mystartups.ph">Kora Dandan-Albano</a><br>
<br>
This is an original story on the legend of the bitter gourd. The story excites the imagination of children and warns them against the evil of envy and greed.
<br><br>
Isang orihinal na kuwento tungkol sa alamat ng ampalaya, pinupukaw nito ang imahinasyon ng mga bata at binabalaan sila sa kasamaang dulot ng pagkainggit at kasakiman.
<br><br>
Finalist – 1995 PBBY-Salanga Prize

(b) Admin Render: line breaks and anchor tags disappeared

(2) I recommend that for old entries, we simply keep them as is. The front end will remain in tact:

(2) I recommend for new entries, we use the new format. It renders better than the old.

(a) Front End

(b) Admin UI

Does this recommendation work for you?

Thank you.

[masarapmabuhay]

Hi Zent, Thank you for the reply.

Therefore, if the client decides to dabble with the product overview field using phpmyadmin, the update will disappear when he/she uses the new Product Management (admin) module.

Would you be able to offer an estimate if we were to enable backward compatibility?

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

On Wed, Apr 11, 2018 at 9:01 PM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

Therefore, if the client decides to dabble with the product overview field using phpmyadmin, the update will disappear when he/she uses the new Product Management (admin) module.

Yes. That is correct.

If the client wishes to use phpmyadmin, then you should release a note that everything should be wrapped around

tags.

Ex:

Hello

Would you be able to offer an estimate if we were to enable backward compatibility?

I can but I think: (1) it's a waste of resources (2) supporting it now will make future maintenance more expensive ause you'll have two branches to worry about.

Recommendation: (1) Phase out the old format (2) Have clients use the new editor (3) For techy client that prefer phpmyadmin, they should see the html format of the new editor anyway. So when they edit using phpmyadmin - the new format is already there.

Morning!

P.S. Finished installing linux. Will install LAMP next.

Thank you.

Peace, Mike

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/87#issuecomment-380443416, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT9KGNn_CVLfJzmIl7KHVsq9QnYpZks5tnf66gaJpZM4TK2Wz .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK! May I ask if this is what you mean by wrapping around <p> tags?

Original Code:

Story by Augie Rivera<br>
Illustrations by <a href="https://www.mystartups.ph">Kora Dandan-Albano</a><br>
<br>
This is an original story on the legend of the bitter gourd. The story excites the imagination of children and warns them against the evil of envy and greed.
<br><br>
Isang orihinal na kuwento tungkol sa alamat ng ampalaya, pinupukaw nito ang imahinasyon ng mga bata at binabalaan sila sa kasamaang dulot ng pagkainggit at kasakiman.
<br><br>
Finalist – 1995 PBBY-Salanga Prize

--

<p> tag-wrapped Code

<p>Story by Augie Rivera</p><p><br/></p>
<p>Illustrations by </p><p><a href="https://www.mystartups.ph">Kora Dandan-Albano</a></p><p><br/></p>
<p><br/></p>
<p>This is an original story on the legend of the bitter gourd. The story excites the imagination of children and warns them against the evil of envy and greed.</p>
<p><br></p><p><br></p>
<p>Isang orihinal na kuwento tungkol sa alamat ng ampalaya, pinupukaw nito ang imahinasyon ng mga bata at binabalaan sila sa kasamaang dulot ng pagkainggit at kasakiman.</p>
<p><br></p><p><br></p>
<p>Finalist – 1995 PBBY-Salanga Prize</p>

If this is what you mean, then at least I have an idea how to resolve this issue in code.

Having said this, let's proceed with the other tasks, while keeping this issue open.

Thank you.

Peace, Mike p.s. OK! I hope that reconstructing the Usbong Store from the ground-up using our Wikis/Guides shouldn't be excessively long. Please never hesitate to update our Wikis/Guides accordingly.

[zent-lim]

Hi Mike,

On Thu, Apr 12, 2018 at 9:09 AM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

OK! May I ask if this is what you mean by wrapping around

tags?

Original Code:

Story by Augie Rivera
Illustrations by Kora Dandan-Albano

This is an original story on the legend of the bitter gourd. The story excites the imagination of children and warns them against the evil of envy and greed.

Isang orihinal na kuwento tungkol sa alamat ng ampalaya, pinupukaw nito ang imahinasyon ng mga bata at binabalaan sila sa kasamaang dulot ng pagkainggit at kasakiman.

Finalist – 1995 PBBY-Salanga Prize

--

tag-wrapped Code

Story by Augie Rivera

Illustrations by

Kora Dandan-Albano

This is an original story on the legend of the bitter gourd. The story excites the imagination of children and warns them against the evil of envy and greed.

Isang orihinal na kuwento tungkol sa alamat ng ampalaya, pinupukaw nito ang imahinasyon ng mga bata at binabalaan sila sa kasamaang dulot ng pagkainggit at kasakiman.

Finalist – 1995 PBBY-Salanga Prize

If this is what you mean, then at least I have an idea how to resolve this issue in code. Yes. Having said this, let's proceed with the other tasks, while keeping this issue open. Ok! Thank you. Peace, Mike p.s. OK! I hope that reconstructing the Usbong Store from the ground-up using our Wikis/Guides shouldn't be excessively long. Please never hesitate to update our Wikis/Guides accordingly. Ok! So far, I havnt seen code update yet that needs to be reflected in wiki.

Evening!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/87#issuecomment-380642794, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT1ZSz9wAry4dhYtLTkAAB9WBy1k2ks5tnqlUgaJpZM4TK2Wz .

[masarapmabuhay]

OK, Zent! Thank you!

Peace, Mike