Created Mobile Responsive Version of b/beverages

[masarapmabuhay]

Hi Zent, I've merged your pull request and have done Unit-Testing.

I found an issue (https://github.com/usbong/UsbongStore/issues/90).

Also, I know that GitHub can show the files you changed in a pull request, but to make it easier for me to identify the parts you edited in the core Usbong Store code, could you include a comment with your name and the date near them?

Example:

//edited by Mike, 20180428
$this->load->view('templates/header', $data);

The date follows the format: YYYYMMDD, or Year (4 digits), Month (2 digits), and Day (2 digits).

Likewise, if I update any portion in any of the modules you're working on, I'll do the same.

If you disagree with this, and/or have suggestions and advice related to this, please never hesitate to tell me.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

(1) Re issue 90, i sent info request.

(2) Re commenting modification dates, it makes messy code. Best to track in git.

U can actually use command git diff. For more info: https://stackoverflow.com/questions/3368590/show-diff-between-commits

Morning!

On Sat, Apr 28, 2018, 3:44 PM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, I've merged your pull request and have done Unit-Testing.

I found an issue (#90 https://github.com/usbong/UsbongStore/issues/90).

Also, I know that GitHub can show the files you changed in a pull request, but to make it easier for me to identify the parts you edited in the core Usbong Store code, could you include a comment with your name and the date near them?

Example:

//edited by Mike, 20180428 $this->load->view('templates/header', $data);

The date follows the format: YYYYMMDD, or Year (4 digits), Month (2 digits), and Day (2 digits).

Likewise, if I update any portion in any of the modules you're working on, I'll do the same.

If you disagree with this, and/or have suggestions and advice related to this, please never hesitate to tell me.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/pull/89#issuecomment-385149974, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT2unIvUFnDS99glxk7ae-QHH3rinks5ttB32gaJpZM4Te3Sp .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

(1) OK!

(2) OK! In that case, I wouldn't require you to add the comments with your name and the date near the portions you modify. --> Having said this, I hope you'll let me continue adding such comments whenever I deem necessary. --> The comments actually do help me do the following:

a) Remember if I've already done a particular code solution, because there would be times when I'd also comment out my earlier solution.

b) Remember when I last updated a particular portion of the code.

c) Remember what I added in the core code.

May I kindly ask if you would agree to include your name and the date, along with the comments you add to explain certain portions of the code?

Thank you.

Peace, Mike

[zent-lim]

Morning Mike,

On Fri, May 4, 2018, 8:46 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

(1) OK!

(2) OK! In that case, I wouldn't require you to add the comments with your name and the date near the portions you modify. --> Having said this, I hope you'll let me continue adding such comments whenever I deem necessary. --> The comments actually do help me do the following:

a) Remember if I've already done a particular code solution, because there would be times when I'd also comment out my earlier solution.

b) Remember when I last updated a particular portion of the code.

c) Remember what I added in the core code.

Ok!

May I kindly ask if you would agree to include your name and the date, along with the comments you add to explain certain portions of the code?

Ok!

For code that's not so easy to follow, i usually have comments placed already.

Do you have a particular patch of code in mind?

Morning!

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/pull/89#issuecomment-386478547, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT6xUcKnlyT-nc1aSHYjpgi7PrsOQks5tu6TWgaJpZM4Te3Sp .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK! Yes, I've seen your comments to explain portions of the code you added.

At present, no, I do not have a particular patch of code in mind.

However, from experience reading and updating your code, I am able to understand what you write.

If there's anything unclear, I would send you a question or open an issue here on GitHub.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

Okly dokly. Morning!

On Sat, May 5, 2018, 8:42 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

OK! Yes, I've seen your comments to explain portions of the code you added.

At present, no, I do not have a particular patch of code in mind.

However, from experience reading and updating your code, I am able to understand what you write.

If there's anything unclear, I would send you a question or open an issue here on GitHub.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/pull/89#issuecomment-386766689, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT840nPDFSXfQ8Af5u9SXYhqW4_iVks5tvPWRgaJpZM4Te3Sp .

[masarapmabuhay]

OK! Thank you!

Peace, Mike