Uneven Margin on Categories Header

[zent-lim]

Hi Mike,

(1) The code below has some items that made design a bit worse (in my opinion)

commit caa30b3d5ad0a2184f04c1d9a1c7d6113da3d4d3

(2) The left and right margin of the categories header are uneven.

(3) The asymmetry is a turn off.

(4) In my opinion, the version I wrote looks better.

Are you sure you'd like to maintain the current look?

[masarapmabuhay]

Hi Zent, Thank you for sending me your findings.

In this case, I'd go with having all the categories in only 1 row.

If you can figure out a way to make the left and right margins of equal length, that would also be OK with me.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

Copy. Pls advice when u re done updating code so we can avoid merge conflicts.

Morning!

On Sat, May 5, 2018, 8:58 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

In this case, I'd go with having all the categories in only 1 row.

If you can figure out a way to make the left and right margins of equal length, that would also be OK with me.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/93#issuecomment-386767813, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT5L9R2c05lkemWlSuPWe44AjkMySks5tvPlSgaJpZM4TyAJ_ .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK. I update/add whatever I can in the code during the day and the evening, although I practice what I call "short bursts (of intense concentration)".

So for a short span of time, about 30 minutes, I'll write code. And then, I'll do something else.

I choose what to do depending on the time that I can allot and the difficulty of what I'm updating/adding.

If we're both working on the Usbong Store code, we can agree to do the following:

1) Modify at our own time only certain modules of the code that are pertinent to what we are doing to minimize merge conflicts.

--> For example, in your case, it would be the beverages page.

2) For overlapping code, e.g. style_v2.php, we'll simply have to spend the time to resolve any issues that may arise due to conflicts upon merging.

--> In this case, we can decide that whenever you're done, you can send me a pull request. --> If I cannot accept your updates/modifications due to other portions of the code breaking upon System-Integration, then I'll tell you.

Having said these, please tell me if you disagree with this type of collaboration.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

All my updates will have to do w beverage page.

It s best i resume when you are done w beverage page. Merge conflict is high probability at this point.

If however, ur update is outside beverage page, no problem. That s not an issue. And i can start writing code.

Plase advice when i can resume writing code.

Thanks.

On Sat, May 5, 2018, 11:15 AM Masarap Mabuhay, notifications@github.com wrote:

Hi Zent, Thank you for the reply.

OK. I update/add whatever I can in the code during the day and the evening, although I practice what I call "short bursts (of intense concentration)".

So for a short span of time, about 30 minutes, I'll write code. And then, I'll do something else.

I choose what to do depending on the time that I can allot and the difficulty of what I'm updating/adding.

If we're both working on the Usbong Store code, we can agree to do the following:

1. Modify at our own time only certain modules of the code that are pertinent to what we are doing to minimize merge conflicts.

For example, in your case, it would be the beverages page.

1. For overlapping code, e.g. style_v2.php, we'll simply have to spend the time to resolve any issues that may arise due to conflicts upon merging.

--> In this case, we can decide that whenever you're done, you can send me a pull request. --> If I cannot accept your updates/modifications due to other portions of the code breaking upon System-Integration, then I'll tell you.

Having said these, please tell me if you disagree with this type of collaboration.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/93#issuecomment-386775139, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT2eAW9Za2ncfA7mS5UP1muUpQRFSks5tvRk-gaJpZM4TyAJ_ .

[masarapmabuhay]

Hi Zent, Thank you for the reply.

OK! Please resume writing code.

Thank you.

Peace, Mike

[zent-lim]

Hi Mike,

Copy.

(1) I'll resume writing code. I'll sync my repo to the latest code again and assume no other updates on beverage pages while I write.

(2) My main to do list is issue 90 - each row should have 5 items.

Have a productive day ahead!

On Sat, May 5, 2018 at 12:36 PM, Masarap Mabuhay notifications@github.com wrote:

Hi Zent, Thank you for the reply.

OK! Please resume writing code.

Thank you.

Peace, Mike

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/usbong/UsbongStore/issues/93#issuecomment-386778529, or mute the thread https://github.com/notifications/unsubscribe-auth/AHplT_S1vXjz2S6MYMBf3Ho9jGJxXLXjks5tvSxAgaJpZM4TyAJ_ .

[masarapmabuhay]

OK, Zent! Thank you!

Peace, Mike

[zent-lim]

Hi Mike,

The remaining item here is the ff: "If you can figure out a way to make the left and right margins of equal length, that would also be OK with me."

This ticket is out of the scope for my deliverables as I have already fixed this on a previous commit.

commit ba60676e7b057ce9a0303aef7f2d881e33d3888d Date: Sun Apr 22 21:08:08 2018 +0800 Note: Fixed mobile responsiveness of b/beverages.

If however we finish remaining tasks earlier, I will be glad to help with this ticket.

I'll wait for your reply on Issue 90.

Morning!

[zent-lim]

Hi Mike,

I have also assigned this ticket to you.

This ticket is out of the scope of our agreement.

Morning!

[masarapmabuhay]

OK, Zent! Thank you!

Peace, Mike