search

usc-cosmolab / hackspace

Materials from CosmoLab group meetings.
MIT License
4 stars 16 forks source link

Feature/data #16

Closed syasini closed 4 years ago

syasini commented 4 years ago

I'm submitting this on behalf of @aryanrahimieh. He was unable to create a pull request from his fork (possibly due to bug in the web browser) so I rewrote and pushed it to the feature/data branch.

I changed the Data attributes x, and y to k and P_k to be more expressive.

I also added the load_pk_data function as a method for the Data class.

syasini commented 4 years ago

Sorry @timothydmorton, I just saw all your comments! :D

Cool, I'll keep it simple. Since you had added the Data class to the data module I thought I would also add the data loading and plotting functions as methods for that.

Should we at least use .k and .P_k instead of .x and .y for data?

syasini commented 4 years ago

I reset the last few commits and made the changes that you requested. Let me know if it looks good.