usc-isi-i2 / t2wml

Table to Wikidata Mapping Language
MIT License
22 stars 11 forks source link

Property description and tags not restored from saved project #618

Closed kyao closed 2 years ago

kyao commented 3 years ago

Property description and tags are not restored from saved project. The same thing happens for apply annotations. The project description and tags are lost as well.

To replicate:

devowit commented 3 years ago

when doing copy annotation we expect to copy properties as they are?

kyao commented 3 years ago

Yes, the properties should stay the same

g1eb commented 3 years ago

Property description is either not exported with .t2wmlz files or not restored to what it was before.

For the property tags I've added a workaround as described in this comment: https://github.com/usc-isi-i2/t2wml/issues/623#issuecomment-910771325

devowit commented 3 years ago

i have fixed this for loading projects, it is merged to development

@kyao , isn't the goal of copying annotations copying the structure? can't the property change between copies, ie in one sheet it's "education level" and in another it's "average score"? in such a case copying the properties over would generate wrong results....

devowit commented 2 years ago

@kyao, should i copy properties with annotations always, or not?

kyao commented 2 years ago

fixed

devowit commented 2 years ago

note: this has specifically been reopened because currently, applying an existing annotation does not copy that annotation's properties.

devowit commented 2 years ago

so I'm closing this in favor of #642 which is clearer