search

usc-isi-i2 / t2wml

Table to Wikidata Mapping Language
MIT License
22 stars 11 forks source link

Property tag form truncated upon restore from t2wmlz file #623

Closed kyao closed 3 years ago

kyao commented 3 years ago

Property tag popup truncated if the session is restored from a t2wmlz file.

image

T2WMLZ file: World_Education_Index_1629916288049.zip

g1eb commented 3 years ago

@kyao upon further inspection, this issue is related to https://github.com/usc-isi-i2/t2wml/issues/604

We should really consider adding the tags directly to the qnode layer. Right now we have to do go and separately check each qnode, and if it does not have tags we have to go fetch those tags separately. This would be a much easier data structure to work with, leading to less render issues down the road. I'll add a workaround for now.

devowit commented 3 years ago

tags are returned with the qnode layer in commit 370cc586602 in branch causx-tags, I'm working on the remaining tag issues and then will merge into development