uscensusbureau / fismatic

https://github.com/uscensusbureau/fismatic/projects/1
Other
11 stars 10 forks source link

python-ssp implementation #60

Open brasky opened 5 years ago

brasky commented 5 years ago

I went ahead and created a PR with an implementation of python-ssp.

Functionally it is the same and I have tested the notebooks in the original version and the python-ssp version and the only change in results was the number of total implementations is now up significantly (in the SSP I used for testing).

I edited the tests to include what I thought was a reasonable base of tests, specifically for control_set since that handles quite a lot of logic. The notebook tests are failing and I believe it's just due to path oddities.

This code is by no means perfect and could certainly be optimized for performance, but my goal was to implement python-ssp without changing the notebooks and have them still work perfectly, which for me they do.

Happy to answer questions, make changes, etc. Really love the project and I'm hoping to use something like this for myself in the future.