uschmann / zipkin-instrumentation-axios

Wrapper to instrument the axios HTTP-client
4 stars 12 forks source link

TypeDef is wrong #3

Open siluri opened 6 years ago

siluri commented 6 years ago

zipkin -> index.d.ts return void

namespace Request {
    function addZipkinHeaders(req: {headers: any}, traceId: TraceId): void;
}

and in your impl.

const config = Request.addZipkinHeaders(opts.headers, traceId);
config.url = url;

that cannot work in TS

siluri commented 6 years ago

https://github.com/openzipkin/zipkin-js/issues/190