search

uschmann / zipkin-instrumentation-axios

Wrapper to instrument the axios HTTP-client
4 stars 12 forks source link

Upgrade zipkin dependency to latest (0.12.0) version #4

Open pathikmehta opened 6 years ago

pathikmehta commented 6 years ago

Currently, zipkin version used in zipkin-instrumentation-axios is 0.6.0. 0.6.0 version of zipkin has 'thrift' dependency included and because of thrift we are getting these errors in our react application.

~/thrift/lib/nodejs/lib/thrift/server.js
Module not found: Error: Can't resolve 'net'...
...
~/thrift/lib/nodejs/lib/thrift/web_server.js
Module not found: Error: Can't resolve 'fs'....
....
/~/thrift/lib/nodejs/lib/thrift/connection.js
Module not found: Error: Can't resolve 'child_process'....
....

They have removed the 'thrift' dependency in the latest zipkin version (0.12.0) so with this version, all above errors should be resolved.

monolithed commented 6 years ago

Are there any updates on this?

geekeren commented 5 years ago

Are there any updates on this?

Can this package meet your requirements? https://www.npmjs.com/package/zipkin-js-instrumentation-axios