uscuni / sgeop

Street geometry processing toolkit
BSD 3-Clause "New" or "Revised" License
13 stars 0 forks source link

document & refactor `artifacts.get_artifacts()` #103

Closed jGaboardi closed 5 hours ago

jGaboardi commented 1 day ago

This PR:

martinfleis commented 1 day ago

Ah, too early to approve. Some failures caught by CI.

codecov[bot] commented 23 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.7%. Comparing base (b2a1e53) to head (7bd0f0d). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/uscuni/sgeop/pull/103/graphs/tree.svg?width=650&height=150&src=pr&token=GFISMU0WPS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uscuni)](https://app.codecov.io/gh/uscuni/sgeop/pull/103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uscuni) ```diff @@ Coverage Diff @@ ## main #103 +/- ## ======================================= + Coverage 98.6% 98.7% +0.1% ======================================= Files 6 6 Lines 921 936 +15 ======================================= + Hits 908 924 +16 + Misses 13 12 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/uscuni/sgeop/pull/103?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uscuni) | Coverage Δ | | |---|---|---| | [sgeop/artifacts.py](https://app.codecov.io/gh/uscuni/sgeop/pull/103?src=pr&el=tree&filepath=sgeop%2Fartifacts.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uscuni#diff-c2dlb3AvYXJ0aWZhY3RzLnB5) | `97.3% <100.0%> (+0.4%)` | :arrow_up: |

🚨 Try these New Features: