Skeletonization in libpysal.cg

uscuni / sgeop

Street geometry processing toolkit

BSD 3-Clause "New" or "Revised" License

10 stars 0 forks source link

Skeletonization in libpysal.cg #22

Open martinfleis opened 3 months ago

martinfleis commented 3 months ago

@jGaboardi a question mostly for you. Given the relatively generic nature of the skeletonization, do you reckon it could be merged upstream to lib?

jGaboardi commented 3 months ago

You are referring to the geometry.voronoi_skeleton() function in uscuni/simplification#95, correct?

martinfleis commented 3 months ago

Yea

martinfleis commented 3 months ago

In maybe a bit more generic shape.

jGaboardi commented 3 months ago

do you reckon it could be merged upstream to lib?

I think there could surely be appetite for that. Especially since it's not all that much code.

jGaboardi commented 2 weeks ago

Moving to sgeop since the will live there soon.

jGaboardi commented 6 days ago

xref #25

now that the geometry.voronoi_skeleton() function is quasi-matured and tested, we may want to revisit this.

martinfleis commented 4 days ago

I'd say that this is not on top of the priority list. Eventually it would be nice but I'd try to finish the stuff that will make it into the publication before looking into this.