explanation of keywords in `geometry.voronoi_skeleton()`?

uscuni / sgeop

Street geometry processing toolkit

BSD 3-Clause "New" or "Revised" License

8 stars 0 forks source link

Open jGaboardi opened 22 hours ago

jGaboardi commented 22 hours ago

Within geometry.voronoi_skeleton() there is some mismatch between the declared keywords and their explanations in the docstrings.

max_segment_length
- is this equivalent to distance or limit_distance in the docstring?
secondary_snap_to
- This basically a safety net of snap_to if declared, right? (see here)

martinfleis commented 22 hours ago

I'll fix that :)

jGaboardi commented 21 hours ago

I'm going to start a PR, that adds some granular tests for voronoi_skeleton(). Do you just want to push the updates to that?