dedicated minimal tests -- `nodes.induce_nodes()`

[jGaboardi]

This PR:

• adds dedicated minimal tests for nodes.induce_nodes()
• xref

  • 21

  • 20

• adds testing
• adds docstrings and type hints

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.3%. Comparing base (dc4324f) to head (5673be6). Report is 2 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/uscuni/sgeop/pull/67?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uscuni) ```diff @@ Coverage Diff @@ ## main #67 +/- ## ===================================== Coverage 98.3% 98.3% ===================================== Files 6 6 Lines 894 897 +3 ===================================== + Hits 879 882 +3 Misses 15 15 ``` | [Files with missing lines](https://app.codecov.io/gh/uscuni/sgeop/pull/67?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uscuni) | Coverage Δ | | |---|---|---| | [sgeop/nodes.py](https://app.codecov.io/gh/uscuni/sgeop/pull/67?src=pr&el=tree&filepath=sgeop%2Fnodes.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uscuni#diff-c2dlb3Avbm9kZXMucHk=) | `98.8% <100.0%> (+<0.1%)` | :arrow_up: |

[jGaboardi]

• Culprit appears to be shapely=2.1.0.dev0+134.g3873635 vs. shapely=2.1.0.dev0+135.g81adc3f
• Not sure if failures are due to precision errors. Seems likely, but will investigate.

Failing

SYSTEM INFO
-----------
python     : 3.12.7 | packaged by conda-forge | (main, Oct  4 2024, 16:05:46) [GCC 13.3.0]
executable : /home/runner/micromamba/envs/py312_sgeop-dev/bin/python
machine    : Linux-6.5.0-1025-azure-x86_64-with-glibc2.35

GEOS, GDAL, PROJ INFO
---------------------
GEOS       : 3.13.0
GEOS lib   : None
GDAL       : 3.9.1
GDAL data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyogrio/gdal_data/
PROJ       : 9.4.1
PROJ data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyproj/proj_dir/share/proj

PYTHON DEPENDENCIES
-------------------
geopandas  : 1.0.1+35.g553fabe
numpy      : 2.1.2
pandas     : 2.2.3
pyproj     : 3.7.0
shapely    : 2.1.0.dev0+135.g81adc3f
pyogrio    : 0.10.0
geoalchemy2: None
geopy      : None
matplotlib : None
mapclassify: None
fiona      : None
psycopg    : None
psycopg2   : None
pyarrow    : 18.0.0

Last passing

SYSTEM INFO
-----------
python     : 3.12.7 | packaged by conda-forge | (main, Oct  4 2024, 16:05:46) [GCC 13.3.0]
executable : /home/runner/micromamba/envs/py312_sgeop-dev/bin/python
machine    : Linux-6.5.0-1025-azure-x86_64-with-glibc2.35

GEOS, GDAL, PROJ INFO
---------------------
GEOS       : 3.13.0
GEOS lib   : None
GDAL       : 3.9.1
GDAL data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyogrio/gdal_data/
PROJ       : 9.4.1
PROJ data dir: /home/runner/micromamba/envs/py312_sgeop-dev/lib/python3.12/site-packages/pyproj/proj_dir/share/proj

PYTHON DEPENDENCIES
-------------------
geopandas  : 1.0.1+35.g553fabe
numpy      : 2.1.2
pandas     : 2.2.3
pyproj     : 3.7.0
shapely    : 2.1.0.dev0+134.g3873635
pyogrio    : 0.10.0
geoalchemy2: None
geopy      : None
matplotlib : None
mapclassify: None
fiona      : None
psycopg    : None
psycopg2   : None
pyarrow    : 18.0.0

[martinfleis]

The shapely difference makes sense as it now uses GEOS to get the polylabel.

[jGaboardi]

@martinfleis Do you have anything against this getting merged? It's a minor refactor, but will help to get massaged into #76 and the GH69_tweaking_loop_logic branch.

We can discuss the dev failures in #75