search

uscuni / sgeop

Street geometry processing toolkit
BSD 3-Clause "New" or "Revised" License
13 stars 0 forks source link

should `nodes._status()` never return `'new'`? #83

Closed jGaboardi closed 1 week ago

jGaboardi commented 2 weeks ago

I find it odd that this line in nodes._status() is never hit during CI, even considering the 6 full FUA tests. Is this something to be concerned about or am I simply not understanding? Or maybe it's a failsafe?

martinfleis commented 1 week ago

It is there just to be safe. It would be hit if we create a new line and in a subsequent step extend it which is not what normally happens. All the new bits are caught likely by the first if.

jGaboardi commented 1 week ago

OK. Good info. I am going to document this within the function itself.