uscuni / simplification

Simplification of street network geometry
Other
10 stars 0 forks source link

reorganize files in /notebooks/ #182

Closed anastassiavybornova closed 4 days ago

anastassiavybornova commented 4 days ago

as part of working on the evaluation & comparison of different methods: shall we reorganize the files in /notebooks/ to make clear which notebooks are part of which workflow?

overview of notebooks we currently have now, grouped by my suggestion of what to do with them:

obsolete

suggestion for all of them: delete? or move to an archive folder?

preprocessing

suggestion for both of them: how about moving this to a subfolder preprocess, and add a comment in the first markdown cell saying that this notebook doesn't have to be run (as the generated input is already provided)?

exploration of different simplification methods

suggestion for all of them: rename into method_{methodname}.ipynb or explore_method_{methodname}.ipynb or similar

(slightly outdated) simplification protocols

suggestion is to replace them with one up-to-date notebook that runs sgeop on the original input data, calling it method_sgeop.ipynb (or whichever name convention we agree upon for the other methods)

(historically relevant) typology exploration notebooks

suggestion is to move them to a subfolder called typology-exploration or the like

evaluation

working on this currently, this will also generate the plots for the paper where we show comparisons between different methods; it might make sense to have one notebook each for comparing manual vs. method outcomes, mirroring the naming convention we choose for the methods notebooks (for example, having methods-osmnx.ipynb where OSMnx simplification is run -- and evaluation-osmnx.ipynb where OSMnx simplification is evaluated)

use cases

anastassiavybornova commented 4 days ago

oooor another option, brainstorming with myself here, how about having /notebooks/ subfolders:

jGaboardi commented 4 days ago

suggestion for all of them: delete? or move to an archive folder?

Probably best to keep in an archive for now.

anastassiavybornova commented 4 days ago

and finally, clustering.ipynb: quote from first cell: Whether it will actualy work, no one knows. We also have no idea which variables shall be measured. :D where should this one live?

martinfleis commented 4 days ago

Agree with everything you said and with how about having /notebooks/ subfolders: even more.

Clustering was a wrong direction. Archive.

anastassiavybornova commented 4 days ago

cool, will reorder & PR now

anastassiavybornova commented 4 days ago

resolved by #187 , xref #188