search

uscuni / simplification

Simplification of street network geometry
Other
6 stars 0 forks source link

OK to add tests for `algorithms/common.py`? #79

Open jGaboardi opened 5 days ago

jGaboardi commented 5 days ago

Do we think the functionality of algorithms/common.py will potentially change due to the stuff happening in momepy^1, or is it safe to start adding tests, etc. for it?

martinfleis commented 5 days ago

I think that he outcome may change little bit. I'd wait.

jGaboardi commented 5 days ago

I might build the bones of testing for it (instance type and geometry type, stuff like that); then fill out tests with expected values after the COINS implementation is settled.

anastassiavybornova commented 4 days ago

+1 for waiting once the coins refactoring is done (and obviously +1 for building the bones already, can't hurt)