search

uscuni / simplification

Simplification of street network geometry
Other
6 stars 0 forks source link

failing CI due to `matplotlib==3.9.0` #86

Open jGaboardi opened 2 days ago

jGaboardi commented 2 days ago

Seems to maybe be some strange new behavior in matplotlib==3.9.0 that is causing a CI failure. I tested this on both geopandas==1.0.0 and geopandas==1.0.1, both were successful on matplotlib==3.8.4 and both failed on matplotlib==3.9.0. Very odd that actual values would differ (see legend).

E           matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 33.877):
E               result_images\test_viz_h3_hex\test_viz_h3_hex_plot_analysis.png
E               result_images\test_viz_h3_hex\test_viz_h3_hex_plot_analysis-expected.png
E               result_images\test_viz_h3_hex\test_viz_h3_hex_plot_analysis-failed-diff.png

C:\Users\runneradmin\micromamba\envs\py311_simplification-latest\Lib\contextlib.py:81: ImageComparisonFailure
strange_matplotlib
anastassiavybornova commented 17 hours ago

Can it have something to do with normalization of scale? Only the scales in the 2 plots are different: on the left it goes from 0 to 3 (or so) and on the right it's much more fine grained (from 0.9 to 1.1), so i think the values are the same (if you look closely, the greyish stuff on the left - has values close to 1 - so does the blueish stuff on the right)

but this one: https://matplotlib.org/stable/api/_as_gen/matplotlib.colors.CenteredNorm.html doesn't seem to have changed from 3.8.x to 3.9 , so not sure where else the rescaling could be happening