Don't process subrecipients for invalid uploads

usdigitalresponse / arpa-reporter

Web app to aid government agencies in reporting on ARPA grants.

Apache License 2.0

3 stars 0 forks source link

Don't process subrecipients for invalid uploads #338

Closed ajhyndman closed 2 years ago

ajhyndman commented 2 years ago

Right now, we process subrecipients on upload. This means that we will capture subrecipients from even invalid uploads.

I am not 100% sure if this is desirable or not, but we should probably check in with partners, and discuss the options.

mattbroussard commented 2 years ago

There is an if (errors.length === 0) check around the update (see here), but it's scoped only within validateSubrecipientRecord so if a given subrecipient record is considered valid but there are errors elsewhere in the spreadsheet, they will not be caught by this check.

igor47 commented 2 years ago

fixed in #380

igor47 commented 2 years ago

closed by #380