usdigitalresponse / cpf-reporter

CPF Reporter application maintained by the USDR Grants program.
Apache License 2.0
0 stars 4 forks source link

[STORY]: Invalidate upload - subrecipients #292

Open ClaireValdivia opened 7 months ago

ClaireValdivia commented 7 months ago

Full User Story

As a staff or admin user, I don't want new subrecipients from invalidated uploads to be included in treasury reports.

Why is this issue important?

When you invalidate an upload, it is not included in the treasury report. However, this currently does not apply to subrecipients who were added, meaning that new subrecipients from invalidated files will still appear in treasury reports incorrectly.

Action Plan

Engineering Tasks

tbd

copied from out of date version of invalidate issue: When Invalidate button is clicked it must:

Acceptance Criteria

When you click "Invalidate" on a valid file:

When you click "Re-validate,"

as1729 commented 4 months ago

Notes from 7/25 call

Sequence of events

## Typical Scenario

Upload 1
Subrecipient 1 - abc - active

Upload 2
Subrecipient 1 - def - active

Upload 2 invalidated
Subrecipient 1 - abc - active (this is fine if it was Name/UEI/TIN then we want to modify it on the subrecipient record)

Upload 1 invalidated
Subrecipient 1 - abc - archived

## Complicated Scenario

Upload 1
Subrecipient 1 - abc - active

Upload 2
Subrecipient 1 - def - active

Upload 3
Subrecipient 2 - abc - active (Should this subrecipient be validated against the latest version of subrecipient 1 or _all_ versions of subrecipient 1?)

Upload 2 invalidated
Subrecipient 1 - abc - active (this is fine if it was Name/UEI/TIN then we want to modify it on the subrecipient record)

Upload 1 invalidated
Subrecipient 1 - abc - archived