search

usdigitalresponse / cpf-reporter

CPF Reporter application maintained by the USDR Grants program.
Apache License 2.0
0 stars 3 forks source link

[Issue]: Adjustments to EC Code & no project errors for upload validation #305

Open ClaireValdivia opened 3 months ago

ClaireValdivia commented 3 months ago

Why is this issue important?

To add clarity to upload validation messages so users are clear as to what they refer to

Current State

Blank EC Code When EC Code is missing from a file, two errors are generating: Image

No Project Records References row 12 Image

Expected State

Blank EC Code We only need the the error that says "Value is required for detailed_expenditure_category" in row 2, column B Remove the error for row 2, column A - this is just help text for the sheet and there is no value that can be submitted

No Project Records "Row" column should list 13

Implementation Plan

The following functions need to be added...

Relevant Code Snippets

No response

ClaireValdivia commented 3 months ago

This is looking good to me in staging!

vshia commented 3 months ago

Here are the updates for the error text: https://github.com/usdigitalresponse/cpf-reporter/pull/307

ClaireValdivia commented 3 months ago

@vshia The no projects message is looking good now!

However, when I try to test an upload with no EC Code selected in the Cover sheet, I get stuck on the Validation in Progress page and never get to validation results. ex upload in staging: https://staging.cpf.usdr.dev/uploads/146

vshia commented 3 months ago

https://github.com/usdigitalresponse/cpf-reporter/pull/322 should address this now

ClaireValdivia commented 3 months ago

this is looking good in staging now, thank you @vshia !