[Issue]: File with old version not generating results or displaying correct warning message

ClaireValdivia commented 3 months ago

Why is this issue important?

Users should be able to upload a file with an old version number and see a warning message that lets them know the version is not the current one.

Current State

When trying to upload this file, it gets stuck on the Validation in Progress screen and does not show the results. When this was previously working, the warning message was incorrect (unable to recreate currently due to the stuck in "validation in progress" issue)

Expected State

If the workbook version is not the current version, the user should receive the following on the validation results page:

Level: Warning Message: “Upload template version ([uploaded template version]) is [older/ newer] than the latest input template ([latest template version])” Tab: Logic Row: 1 Col: B

Implementation Plan

The following functions need to be added...

Relevant Code Snippets

No response

vshia commented 3 months ago

https://github.com/usdigitalresponse/cpf-reporter/pull/342 should add the warning copy and fix the hanging validation

ClaireValdivia commented 2 months ago

@vshia thanks so much!! I'm now able to get to the validation results page, but still seeing a couple issues:

It looks like this file is not passing validation even though there is only a warning displaying. We would expect that if there are no Errors in the level column that validation would pass.
Could we clean up the text of the message to read "“Upload template version ([uploaded template version]) is [older/ newer] than the latest input template ([latest template version])”? It looks like there's extra text before and after this in the Message.

ClaireValdivia commented 2 months ago

@vshia this is looks great now, thank you!

usdigitalresponse / cpf-reporter