Close date 1/1/2100 on My Grants and Browse Grants Tables

ClaireValdivia commented 11 months ago

Why is this issue important?

In grants.gov, there are a number of grants that don't have a close date and instead have a message display. Currently we insert close_date of 1/1/2100 during ingestion when "closeDate" is not available. This displays on the grants results table and grants details page. This isn't ideal as it doesn't give the user much information or context and is a bit confusing when sorting the table. When we took a snapshot of what these messages are, about half are "Proposals accepted anytime" but otherwise the messages vary a lot and can be as long as full paragraphs. https://docs.google.com/spreadsheets/d/1FxrMjpz0-iW0_WcLgY3CH_OreMBf2L0dntR_mzbroXQ/edit?usp=sharing

Tasks

[x] Confirm rule for when 1/1/2100 date is getting filled in - is it anytime a date is not entered in the field? Confirmed behavior (see Dave's comment below)
[x] Can we Export all grants with an opp status of Posted and a close date of 1/1/2100, and include what the original data from grants.gov is for the Close Date field? Hoping to use this to assess if there are common messages we can build rules around - done! google sheet with pivot table linked in comments
[ ] Determine path forward for displaying grants that currently have 1/1/2100 close date. Consider if we want to plan changes to grants results table, grants details page, or otherwise

Expected State

Grants table on My Grants and Browse Grants Tabs:

[ ] If close date is blank AND opp status = posted - then display "Not yet issued" in the Close Date column
[ ] If Estimated Application Due Date is blank AND opp status = forecasted - then display "Not yet issued" in the Close Date column
[ ] If opp status = forecasted, and Estimated Application Due Date has a date entered, then display "est." and the date from Estimated Application Due Date field in the Close Date column (i.e. "est. 12/20/2023")
[ ] if opp status = Posted, Archived, or Closed, and Close Date is anything other than a date or blank, display: "see details" in the Close Date column
[ ] if opp status = Forecasted, and Estimated Application Due Date is anything other than a date or blank, display: "see details" in the Close Date column

Note that this issue is only for table display. #2571 addressed display on grant details page

Implementation Plan

tbd

Relevant Code Snippets

No response

replicantSocks commented 11 months ago

Some technical notes: we insert close_date of 1/1/2100 during ingestion when "closeDate" is not available.

"closeDate" is a return field from the search call to grants.gov (rather than from the secondary per grant call where each field is enhanced with additional data).

It seems like grants 'detail page' fills in its "Current Closing Date For Applications" from a set of potential fields, but ultimately it seems like it's a free form placeholder as described above.

replicantSocks commented 10 months ago

Here's a CSV containing all of the posted grants with no close date (which we display as 1/1/2100). It also contains their original and current response dates and descriptions. These are what get displayed on the grants detail pages. GrantsPostedNoCloseDateDescriptions.csv

At a glance, 'Proposals accepted anytime' occurs something like 80 times within the set of 224, the next most common phrase occurs 11 times, and the others mostly occur once.

One option would be to handle the 'Proposals accepted anytime' cases directly and provide a link where a more detailed description exists.

ClaireValdivia commented 10 months ago

@caitlinwinner curious for your thoughts here... actually wondering if there's any opportunity for this to be considered with the grants details page redesign - like perhaps the results table could say something like "click grant to see details" and then the grant details page could show the full messages? fyi @jsandlund (don't see lawrence on github yet!)

made a pivot table here of the frequency of messages from what Dave pulled. about half say "Proposals accepted anytime" but lots of variability of messages otherwise. https://docs.google.com/spreadsheets/d/1FxrMjpz0-iW0_WcLgY3CH_OreMBf2L0dntR_mzbroXQ/edit?usp=sharing

caitlinwinner commented 10 months ago

Designs https://www.figma.com/file/N1wuvwvciNhdKZNSdomTqn/Forecasted?type=design&node-id=0%3A1&mode=design&t=XfCrk3DmM98qakJR-1

ClaireValdivia commented 9 months ago

If blank AND posted status - then "Not yet issued" If forecasted and date from estimated field - then "est. DATE" if anything other than a date or blank, "see details"

*in grants details, whatever is in grants.gov will show. blank should show NA

ClaireValdivia commented 9 months ago

@caitlinwinner and @lawrence-zheng - I updated the requirements on the issue, but realized that we don't yet have guidance for what should display is the close date or estimated application due date should display on the grant details page if it is blank or text. I'm looking at the current figma files, and not sure if we've landing on the grants details page still showing "valid from XX - XX" or if we will show separate fields for open and close date, as I imagine that would change how we'd consider displaying blank or text content for the close date.

lawrence-zheng commented 9 months ago

See the "Date field" frame in the "Redesign spec 12/18/23" page of the Figma file for information on the date display for the Grant Details page https://www.figma.com/file/yQx55VTr5awPYClHIJCz8y/Grant-Details?type=design&node-id=722%3A3780&mode=design&t=XowP4cmqFnGHQRRL-1

ClaireValdivia commented 6 months ago

closing this issue out in favor of https://github.com/usdigitalresponse/usdr-gost/issues/2201

usdigitalresponse / usdr-gost