Open ClaireValdivia opened 9 months ago
Does this issue include the task of cleaning up the related dead code? (Like the GrantDetailsLegacy
modal?) Just wanted to make sure that's tracked somewhere.
@jeffsmohan I think that would be great to include on this issue - would you be able to add in notes on which dead code to remove? Thank you!
✅ Updated implementation details to reflect the dead code to remove
@TylerHendrickson just moved this to Ready as I noticed it has implementation details, but wondering if we should also add into this to remove the shareTerminologyEnabled
feature flag to this as well?
Why is this issue important?
After grant details work is implemented for 2 weeks and is stable, we can remove the related feature flags. We also want to remove dead code from the previous implementation of grant details that is no longer relevant.
Implementation Plan
Feature flag definitions to remove:
newGrantsDetailPageEnabled
prod.tfvars
,staging.tfvars
, andsandbox.tfvars
deploy-config.js
andhelpers/featureFlags/index.js
Dead code to remove:
router/index.js
: removerequiresNewGrantsDetailPageEnabled
checkGrantsTable.vue
,Dashboard.vue
,RecentActivity.vue
,UpcomingCloseDates.vue
: code to switch between legacy vs the new grant detail viewGrantDetailsLegacy.vue
: remove entirelyRelevant Code Snippets
No response