usdigitalresponse / usdr-gost

USDR-hosted grants management tools
http://grants.usdigitalresponse.org
Apache License 2.0
31 stars 21 forks source link

Clean up grant details feature flags and dead code #2686

Open ClaireValdivia opened 9 months ago

ClaireValdivia commented 9 months ago

Why is this issue important?

After grant details work is implemented for 2 weeks and is stable, we can remove the related feature flags. We also want to remove dead code from the previous implementation of grant details that is no longer relevant.

Implementation Plan

Feature flag definitions to remove:

Dead code to remove:

Relevant Code Snippets

No response

jeffsmohan commented 8 months ago

Does this issue include the task of cleaning up the related dead code? (Like the GrantDetailsLegacy modal?) Just wanted to make sure that's tracked somewhere.

ClaireValdivia commented 8 months ago

@jeffsmohan I think that would be great to include on this issue - would you be able to add in notes on which dead code to remove? Thank you!

jeffsmohan commented 8 months ago

✅ Updated implementation details to reflect the dead code to remove

ClaireValdivia commented 1 month ago

@TylerHendrickson just moved this to Ready as I noticed it has implementation details, but wondering if we should also add into this to remove the shareTerminologyEnabled feature flag to this as well?